[PR #4829] [MERGED] fix: environment variable not working on auth #4953

Closed
opened 2026-03-17 02:26:45 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4829
Author: @nivedin
Created: 3/5/2025
Status: Merged
Merged: 3/5/2025
Merged by: @jamesgeorge007

Base: patchHead: fix/env-variable-bug-in-auth


📝 Commits (1)

  • 5c795d9 fix: environment variable bug in auth

📊 Changes

1 file changed (+184 additions, -165 deletions)

View changed files

📝 packages/hoppscotch-kernel/src/relay/impl/web/v/1.ts (+184 -165)

📄 Description

Closes #4808

This PR fixes the issue where the environment variable was not getting parsed while using with authorization.

Double auth processing was happening one in EffectiveURL and other one in relay, but it was done without the parsed auth value, so the code has been temporarily commented out, till a effective way is implemented.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4829 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 3/5/2025 **Status:** ✅ Merged **Merged:** 3/5/2025 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `patch` ← **Head:** `fix/env-variable-bug-in-auth` --- ### 📝 Commits (1) - [`5c795d9`](https://github.com/hoppscotch/hoppscotch/commit/5c795d962bd83ee590a9f61e682a377e2c55caeb) fix: environment variable bug in auth ### 📊 Changes **1 file changed** (+184 additions, -165 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-kernel/src/relay/impl/web/v/1.ts` (+184 -165) </details> ### 📄 Description Closes #4808 This PR fixes the issue where the environment variable was not getting parsed while using with authorization. Double auth processing was happening one in EffectiveURL and other one in relay, but it was done without the parsed auth value, so the code has been temporarily commented out, till a effective way is implemented. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 02:26:45 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4953
No description provided.