[PR #4623] [MERGED] fix: read data from DB for latest value #4873

New issue

Closed

opened 2026-03-17 02:22:13 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:22:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4623
Author: @mirarifhasan
Created: 12/17/2024
Status: ✅ Merged
Merged: 12/18/2024
Merged by: @jamesgeorge007

Base: next ← Head: fix/read-from-db-avoid-concurrent-issue

📝 Commits (1)

12aa9cc fix: read from DB for latest value in case of concurrent function call

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 packages/hoppscotch-backend/src/infra-config/infra-config.service.ts (+3 -3)

📄 Description

Closes HSB-515

What's changed

Currently, data is read from the ConfigService to avoid DB calls. But an issue arises, that function is called by different caller functions, where Config Service returns the same data instead of the latest.

Notes to reviewers

Disable SMTP auth and save. Then try to toggle any other SSO and save. If the SSO changes persists then good to go.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4623 **Author:** [@mirarifhasan](https://github.com/mirarifhasan) **Created:** 12/17/2024 **Status:** ✅ Merged **Merged:** 12/18/2024 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `next` ← **Head:** `fix/read-from-db-avoid-concurrent-issue` --- ### 📝 Commits (1) - [`12aa9cc`](https://github.com/hoppscotch/hoppscotch/commit/12aa9cc7f83a9862eea4aece8befb5afd33ebcd0) fix: read from DB for latest value in case of concurrent function call ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-backend/src/infra-config/infra-config.service.ts` (+3 -3) </details> ### 📄 Description    Closes HSB-515  ### What's changed  Currently, data is read from the `ConfigService` to avoid DB calls. But an issue arises, that function is called by different caller functions, where Config Service returns the same data instead of the latest.  ### Notes to reviewers  Disable SMTP auth and save. Then try to toggle any other SSO and save. If the SSO changes persists then good to go. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>