[PR #3978] [MERGED] fix: use pressed key rather than its code #4623

New issue

Closed

opened 2026-03-17 02:08:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:08:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3978
Author: @posva
Created: 4/15/2024
Status: ✅ Merged
Merged: 4/19/2024
Merged by: @AndrewBastin

Base: release/2024.3.1 ← Head: fix-keybindings

📝 Commits (3)

2ac4112 fix: use pressed key rather than its code
e420160 Update packages/hoppscotch-common/src/helpers/keybindings.ts
dae3cc9 refactor: updated logic for letter and digit check and reverted back to using ev.key

📊 Changes

3 files changed (+14857 additions, -12786 deletions)

View changed files

📝 packages/hoppscotch-common/src/components.d.ts (+204 -204)
📝 packages/hoppscotch-common/src/helpers/keybindings.ts (+10 -17)
📝 pnpm-lock.yaml (+14643 -12565)

📄 Description

Fix #3833

Closes #

Description

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

Additional Information

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3978 **Author:** [@posva](https://github.com/posva) **Created:** 4/15/2024 **Status:** ✅ Merged **Merged:** 4/19/2024 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2024.3.1` ← **Head:** `fix-keybindings` --- ### 📝 Commits (3) - [`2ac4112`](https://github.com/hoppscotch/hoppscotch/commit/2ac41125bf11e9e8e17d58fe8e9407eb3267501a) fix: use pressed key rather than its code - [`e420160`](https://github.com/hoppscotch/hoppscotch/commit/e420160a12b8017681089fd3742c3dcd4ef66e59) Update packages/hoppscotch-common/src/helpers/keybindings.ts - [`dae3cc9`](https://github.com/hoppscotch/hoppscotch/commit/dae3cc954ce271677020d6c427b259af988cd6c0) refactor: updated logic for letter and digit check and reverted back to using ev.key ### 📊 Changes **3 files changed** (+14857 additions, -12786 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components.d.ts` (+204 -204) 📝 `packages/hoppscotch-common/src/helpers/keybindings.ts` (+10 -17) 📝 `pnpm-lock.yaml` (+14643 -12565) </details> ### 📄 Description Fix #3833   Closes #  ### Description   ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [ ] All the tests have passed ### Additional Information  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>