[PR #4587] [MERGED] fix: add tab id while opening tab #4861

Closed
opened 2026-03-17 02:21:40 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4587
Author: @nivedin
Created: 12/3/2024
Status: Merged
Merged: 12/16/2024
Merged by: @jamesgeorge007

Base: patchHead: fix/gql-tab-id-bug


📝 Commits (1)

  • 8d6b747 fix: add tab id while opening tab

📊 Changes

2 files changed (+3 additions, -17 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/collections/graphql/index.vue (+2 -16)
📝 packages/hoppscotch-common/src/components/http/test/Runner.vue (+1 -1)

📄 Description

Closes #4500

This PR fixes the issue where the GQL tab changes doesn't get updated in the db.

What's changed

The collection request id wasn't attached to the active tab while saving, now the full request is added to the tab.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4587 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 12/3/2024 **Status:** ✅ Merged **Merged:** 12/16/2024 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `patch` ← **Head:** `fix/gql-tab-id-bug` --- ### 📝 Commits (1) - [`8d6b747`](https://github.com/hoppscotch/hoppscotch/commit/8d6b74788423337660e25f932f3b98c9242454c6) fix: add tab id while opening tab ### 📊 Changes **2 files changed** (+3 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/collections/graphql/index.vue` (+2 -16) 📝 `packages/hoppscotch-common/src/components/http/test/Runner.vue` (+1 -1) </details> ### 📄 Description <!-- Thanks for creating this pull request 🤗 Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one. --> <!-- If this pull request closes an issue, please mention the issue number below --> Closes #4500 This PR fixes the issue where the GQL tab changes doesn't get updated in the db. ### What's changed The collection request id wasn't attached to the active tab while saving, now the full request is added to the tab. <!-- You can also choose to add a list of changes and if they have been completed or not by using the markdown to-do list syntax - [ ] Not Completed - [x] Completed --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 02:21:40 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4861
No description provided.