[PR #3702] [CLOSED] refactor: improvements to users module in admin dashboard #4500

New issue

Closed

opened 2026-03-17 02:01:46 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:01:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3702
Author: @joeljstephen
Created: 12/28/2023
Status: ❌ Closed

Base: release/2023.12.3 ← Head: refactor/dashboard-users

📝 Commits (10+)

1b821e7 refactor: better i18n syntax in shared requests component
598fe72 chore: better import organization in Details component
ab0af5e refactor: better i18n syntax in invite modal component
59e20cf refactor: better promise and i18n syntax in index component and removed watcher
051ce08 chore: better import organization in invited component
e98730e refactor: better promise and i18n syntax in id component
7136079 refactor: code improvements across users module related components and updated client handler
030a952 style: horizontal padding for shared requests component
817ac45 refactor: better types for useClientHandler
2e7e6a3 style: lesser top margin for user details page

📊 Changes

10 files changed (+267 additions, -286 deletions)

View changed files

📝 packages/hoppscotch-sh-admin/locales/en.json (+1 -0)
📝 packages/hoppscotch-sh-admin/src/components.d.ts (+42 -42)
📝 packages/hoppscotch-sh-admin/src/components/teams/Invite.vue (+1 -1)
📝 packages/hoppscotch-sh-admin/src/components/users/Details.vue (+2 -6)
📝 packages/hoppscotch-sh-admin/src/components/users/InviteModal.vue (+3 -7)
📝 packages/hoppscotch-sh-admin/src/components/users/SharedRequests.vue (+96 -96)
📝 packages/hoppscotch-sh-admin/src/composables/useClientHandler.ts (+15 -10)
📝 packages/hoppscotch-sh-admin/src/pages/users/_id.vue (+51 -49)
📝 packages/hoppscotch-sh-admin/src/pages/users/index.vue (+54 -71)
📝 packages/hoppscotch-sh-admin/src/pages/users/invited.vue (+2 -4)

📄 Description

Ticket

Closes HFE-377

Description

This PR focuses on improving the users module in Admin Dashboard. Each component related to the users module is refactored and improved upon and minor bugs found are fixed.

Objectives

Refactor users module in admin dashboard

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3702 **Author:** [@joeljstephen](https://github.com/joeljstephen) **Created:** 12/28/2023 **Status:** ❌ Closed **Base:** `release/2023.12.3` ← **Head:** `refactor/dashboard-users` --- ### 📝 Commits (10+) - [`1b821e7`](https://github.com/hoppscotch/hoppscotch/commit/1b821e79ab67e6e9472838c685e832df6a131324) refactor: better i18n syntax in shared requests component - [`598fe72`](https://github.com/hoppscotch/hoppscotch/commit/598fe7235cd09251711c837ec246267748f611c2) chore: better import organization in Details component - [`ab0af5e`](https://github.com/hoppscotch/hoppscotch/commit/ab0af5e51abc1b472d7cf30092f8b57f76bbe799) refactor: better i18n syntax in invite modal component - [`59e20cf`](https://github.com/hoppscotch/hoppscotch/commit/59e20cff367daa3b26150da7b92486d291210649) refactor: better promise and i18n syntax in index component and removed watcher - [`051ce08`](https://github.com/hoppscotch/hoppscotch/commit/051ce08e112e1326f90d731fdd4bdf65b9debcc7) chore: better import organization in invited component - [`e98730e`](https://github.com/hoppscotch/hoppscotch/commit/e98730ea9ad5c80ca2cb9d61e1a26f69654b13b4) refactor: better promise and i18n syntax in id component - [`7136079`](https://github.com/hoppscotch/hoppscotch/commit/71360795341882436f366b173e47d1fb8b04425b) refactor: code improvements across users module related components and updated client handler - [`030a952`](https://github.com/hoppscotch/hoppscotch/commit/030a952d16ead8bce19cc593fad42784653fd974) style: horizontal padding for shared requests component - [`817ac45`](https://github.com/hoppscotch/hoppscotch/commit/817ac45081f7e36b165497d892c0fbc45bfe3550) refactor: better types for useClientHandler - [`2e7e6a3`](https://github.com/hoppscotch/hoppscotch/commit/2e7e6a3a22e7a9d2ca6891ba0c0c3b40e76780a5) style: lesser top margin for user details page ### 📊 Changes **10 files changed** (+267 additions, -286 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-sh-admin/locales/en.json` (+1 -0) 📝 `packages/hoppscotch-sh-admin/src/components.d.ts` (+42 -42) 📝 `packages/hoppscotch-sh-admin/src/components/teams/Invite.vue` (+1 -1) 📝 `packages/hoppscotch-sh-admin/src/components/users/Details.vue` (+2 -6) 📝 `packages/hoppscotch-sh-admin/src/components/users/InviteModal.vue` (+3 -7) 📝 `packages/hoppscotch-sh-admin/src/components/users/SharedRequests.vue` (+96 -96) 📝 `packages/hoppscotch-sh-admin/src/composables/useClientHandler.ts` (+15 -10) 📝 `packages/hoppscotch-sh-admin/src/pages/users/_id.vue` (+51 -49) 📝 `packages/hoppscotch-sh-admin/src/pages/users/index.vue` (+54 -71) 📝 `packages/hoppscotch-sh-admin/src/pages/users/invited.vue` (+2 -4) </details> ### 📄 Description ### Ticket Closes HFE-377 ### Description This PR focuses on improving the users module in Admin Dashboard. Each component related to the users module is refactored and improved upon and minor bugs found are fixed. ### Objectives - [x] Refactor users module in admin dashboard ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>