mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[PR #4480] [MERGED] feat: ability for aio in sub-path access configurations to specify alternate ports #4823
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#4823
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/4480
Author: @AndrewBastin
Created: 10/25/2024
Status: ✅ Merged
Merged: 10/28/2024
Merged by: @AndrewBastin
Base:
next← Head:feat/aio-alternate-port📝 Commits (1)
88ddf5ffeat: add ability for aio containers to specify alternate binding ports📊 Changes
3 files changed (+3 additions, -17 deletions)
View changed files
📝
aio-multiport-setup.Caddyfile(+0 -4)📝
aio-subpath-access.Caddyfile(+1 -13)📝
prod.Dockerfile(+2 -0)📄 Description
This PR allows for users to specify alternate ports for AIO container configurations having sub-path access (single port) configurations. The container normally binds port 80 when using single port access, but port 80 is a privileged port and certain systems (esp. rootless systems like Podman or hardened systems like OpenShift) do not provide root level privileges to allow for binding to port 80.
What's changed
HOPP_AIO_ALTERNATE_PORTwhich is used by Caddy to define which port is to be bound to. No behaviour change for non-AIO containers.Notes
@SanskritiHarmukh do remind me to update the docs to add a section for this.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.