[PR #3664] [MERGED] fix(common): ensure the add-environment modal value field is empty when opened via the inspector #4480

New issue

Closed

opened 2026-03-17 02:00:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:00:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3664
Author: @jamesgeorge007
Created: 12/18/2023
Status: ✅ Merged
Merged: 12/18/2023
Merged by: @AndrewBastin

Base: release/2023.12.0 ← Head: hotfix/inspector-add-env-flow

📝 Commits (2)

20bd70e fix: ensure the add-environment modal value field is empty when opened via the inspector
a76ab3e refactor: make variable name fallback to an empty string

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/environments/index.vue (+1 -1)

📄 Description

Description

When opened via the inspector, the add environment modal showed the value associated with the previous attempt to set an environment via the context menu. This PR aims to fix this behavior by removing the truthy check before assigning environment values at the parent environments component, thereby permitting empty strings.

https://github.com/hoppscotch/hoppscotch/assets/25279263/9dd2e560-bfb8-4152-819c-90a0e07f84ce

Closes HFE-347.

Checks

My pull request adheres to the code style of this project
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3664 **Author:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Created:** 12/18/2023 **Status:** ✅ Merged **Merged:** 12/18/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.12.0` ← **Head:** `hotfix/inspector-add-env-flow` --- ### 📝 Commits (2) - [`20bd70e`](https://github.com/hoppscotch/hoppscotch/commit/20bd70eac1dc5c3e5c5060a3c8a88bef85f025b8) fix: ensure the add-environment modal value field is empty when opened via the inspector - [`a76ab3e`](https://github.com/hoppscotch/hoppscotch/commit/a76ab3ef112854d90d5c97eb97890479c8061d61) refactor: make variable name fallback to an empty string ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/environments/index.vue` (+1 -1) </details> ### 📄 Description ### Description When opened via the inspector, the add environment modal showed the value associated with the previous attempt to set an environment via the context menu. This PR aims to fix this behavior by removing the truthy check before assigning environment values at the parent environments component, thereby permitting empty strings. https://github.com/hoppscotch/hoppscotch/assets/25279263/9dd2e560-bfb8-4152-819c-90a0e07f84ce Closes HFE-347. ### Checks - [x] My pull request adheres to the code style of this project - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>