[PR #4462] [MERGED] fix: prevent keypress actions in the loading state #4811

New issue

Closed

opened 2026-03-17 02:18:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:18:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4462
Author: @xLansang
Created: 10/21/2024
Status: ✅ Merged
Merged: 10/22/2024
Merged by: @jamesgeorge007

Base: next ← Head: main

📝 Commits (2)

35496c3 Handle multiple request on repeated keypresses
b354abd chore: skip validations if in the loading state

📊 Changes

8 files changed (+34 additions, -0 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/collections/Add.vue (+4 -0)
📝 packages/hoppscotch-common/src/components/collections/AddFolder.vue (+5 -0)
📝 packages/hoppscotch-common/src/components/collections/AddRequest.vue (+5 -0)
📝 packages/hoppscotch-common/src/components/collections/Edit.vue (+4 -0)
📝 packages/hoppscotch-common/src/components/collections/EditFolder.vue (+4 -0)
📝 packages/hoppscotch-common/src/components/collections/EditRequest.vue (+4 -0)
📝 packages/hoppscotch-common/src/components/environments/teams/Details.vue (+4 -0)
📝 packages/hoppscotch-common/src/components/teams/Add.vue (+4 -0)

📄 Description

This PR adds a check condition to the multiple cases where a repeated keypress will create multiple requests while in loading state. The changes made closes the issue #4134.

Closes HFE-474.

What's changed

In collections, functions that add or edit collections now return early if the button is in loading state.
Similarly, add or edit functions in environment and teams also return early in loading state.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4462 **Author:** [@xLansang](https://github.com/xLansang) **Created:** 10/21/2024 **Status:** ✅ Merged **Merged:** 10/22/2024 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `next` ← **Head:** `main` --- ### 📝 Commits (2) - [`35496c3`](https://github.com/hoppscotch/hoppscotch/commit/35496c3c4b26558ea35e47b5796df77f7fc1747b) Handle multiple request on repeated keypresses - [`b354abd`](https://github.com/hoppscotch/hoppscotch/commit/b354abd5ffca5341ffd7b23a2dce43022f273dd4) chore: skip validations if in the loading state ### 📊 Changes **8 files changed** (+34 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/collections/Add.vue` (+4 -0) 📝 `packages/hoppscotch-common/src/components/collections/AddFolder.vue` (+5 -0) 📝 `packages/hoppscotch-common/src/components/collections/AddRequest.vue` (+5 -0) 📝 `packages/hoppscotch-common/src/components/collections/Edit.vue` (+4 -0) 📝 `packages/hoppscotch-common/src/components/collections/EditFolder.vue` (+4 -0) 📝 `packages/hoppscotch-common/src/components/collections/EditRequest.vue` (+4 -0) 📝 `packages/hoppscotch-common/src/components/environments/teams/Details.vue` (+4 -0) 📝 `packages/hoppscotch-common/src/components/teams/Add.vue` (+4 -0) </details> ### 📄 Description This PR adds a check condition to the multiple cases where a repeated keypress will create multiple requests while in loading state. The changes made closes the issue #4134. Closes HFE-474. ### What's changed - In collections, functions that add or edit collections now return early if the button is in loading state. - Similarly, add or edit functions in environment and teams also return early in loading state. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>