[PR #3643] [MERGED] fix: overflowing modal fix on small screens #4462

New issue

Closed

opened 2026-03-17 01:59:51 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:59:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3643
Author: @ajmalmohad
Created: 12/12/2023
Status: ✅ Merged
Merged: 12/12/2023
Merged by: @AndrewBastin

Base: release/2023.12.0 ← Head: bug/overflowing-modal

📝 Commits (2)

600d4b7 fix: overflowing modal fix on small screens
1793002 chore: improve styles

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 packages/hoppscotch-ui/src/components/smart/Modal.vue (+1 -1)

📄 Description

Modal max height is set based on view port size instead of using hard coded value

Closes #3642

Description

Used 60vh as body height of modal instead of lg

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

Additional Information

Screencast from 12-12-23 01:18:44 PM IST.webm

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3643 **Author:** [@ajmalmohad](https://github.com/ajmalmohad) **Created:** 12/12/2023 **Status:** ✅ Merged **Merged:** 12/12/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.12.0` ← **Head:** `bug/overflowing-modal` --- ### 📝 Commits (2) - [`600d4b7`](https://github.com/hoppscotch/hoppscotch/commit/600d4b72e38a0af1db02d0a3204d9795b7851a8a) fix: overflowing modal fix on small screens - [`1793002`](https://github.com/hoppscotch/hoppscotch/commit/1793002ca3e47c7816d0f0850a2c45a5a6fdeeeb) chore: improve styles ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-ui/src/components/smart/Modal.vue` (+1 -1) </details> ### 📄 Description Modal max height is set based on view port size instead of using hard coded value   Closes #3642 ### Description Used `60vh` as body height of modal instead of `lg`  ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed ### Additional Information [Screencast from 12-12-23 01:18:44 PM IST.webm](https://github.com/hoppscotch/hoppscotch/assets/55492635/6c66bb13-2ea3-4197-8929-6d18cfcb5528) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>