[PR #4363] [MERGED] chore: make client secret optional across grant types #4769

New issue

Closed

opened 2026-03-17 02:16:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:16:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4363
Author: @amk-dev
Created: 9/19/2024
Status: ✅ Merged
Merged: 9/27/2024
Merged by: @jamesgeorge007

Base: next ← Head: chore/allow-empty-client-credentials

📝 Commits (7)

604c9eb chore: make client secret optional across grant types
c91071a chore: fix type errors
9aa1701 chore: update auth in collection schema
ea725c5 chore: update versions in tests
b433215 chore: revert changes to AuthCodeGrantTypeParams schema definition
e7bf28a chore: account for new HoppCollection schema in syncing context
e2352ff test: resolve failing tests

📊 Changes

16 files changed (+256 additions, -42 deletions)

View changed files

📝 packages/hoppscotch-cli/src/__tests__/unit/workspace-access.spec.ts (+28 -3)
📝 packages/hoppscotch-common/src/components/http/authorization/OAuth2.vue (+13 -3)
📝 packages/hoppscotch-common/src/services/oauth/flows/clientCredentials.ts (+4 -2)
📝 packages/hoppscotch-common/src/services/oauth/flows/password.ts (+4 -2)
📝 packages/hoppscotch-common/src/services/persistence/__tests__/__mocks__/index.ts (+5 -5)
📝 packages/hoppscotch-data/src/collection/index.ts (+4 -2)
📝 packages/hoppscotch-data/src/collection/v/3.ts (+1 -1)
➕ packages/hoppscotch-data/src/collection/v/4.ts (+37 -0)
📝 packages/hoppscotch-data/src/graphql/index.ts (+6 -3)
📝 packages/hoppscotch-data/src/graphql/v/3.ts (+2 -2)
📝 packages/hoppscotch-data/src/graphql/v/4.ts (+2 -2)
📝 packages/hoppscotch-data/src/graphql/v/6.ts (+1 -1)
➕ packages/hoppscotch-data/src/graphql/v/7.ts (+49 -0)
📝 packages/hoppscotch-data/src/rest/index.ts (+17 -12)
➕ packages/hoppscotch-data/src/rest/v/8.ts (+79 -0)
📝 packages/hoppscotch-selfhost-web/src/platform/collections/collections.platform.ts (+4 -4)

📄 Description

Changes

Makes client_secret optional for clientCredentials and password oauth flows.
Some schemas were imported with the latest version of dependent schemas instead of the one compatible with them. This PR fixes those imports to point to the correct schemas.
Update the collection schema to use the updated auth schemas
Test suite updates accounting for version bumps at the schema level.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4363 **Author:** [@amk-dev](https://github.com/amk-dev) **Created:** 9/19/2024 **Status:** ✅ Merged **Merged:** 9/27/2024 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `next` ← **Head:** `chore/allow-empty-client-credentials` --- ### 📝 Commits (7) - [`604c9eb`](https://github.com/hoppscotch/hoppscotch/commit/604c9ebce78efee7d2e0c5eb27c4ae8725291a19) chore: make client secret optional across grant types - [`c91071a`](https://github.com/hoppscotch/hoppscotch/commit/c91071a0e3987a8ad0dccc089d5d1eb1d35288ce) chore: fix type errors - [`9aa1701`](https://github.com/hoppscotch/hoppscotch/commit/9aa1701fb0d8f6e6bb606108f66d03f63fc49c72) chore: update auth in collection schema - [`ea725c5`](https://github.com/hoppscotch/hoppscotch/commit/ea725c50caf05b8fd6f0268e44b0c502a30ed4b3) chore: update versions in tests - [`b433215`](https://github.com/hoppscotch/hoppscotch/commit/b433215b271f6e277d418bc553e89a5177da9442) chore: revert changes to `AuthCodeGrantTypeParams` schema definition - [`e7bf28a`](https://github.com/hoppscotch/hoppscotch/commit/e7bf28af58020d1290f52f7bf6715b658437886a) chore: account for new `HoppCollection` schema in syncing context - [`e2352ff`](https://github.com/hoppscotch/hoppscotch/commit/e2352fffaeeb36aa4840d9197351874cf686104a) test: resolve failing tests ### 📊 Changes **16 files changed** (+256 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-cli/src/__tests__/unit/workspace-access.spec.ts` (+28 -3) 📝 `packages/hoppscotch-common/src/components/http/authorization/OAuth2.vue` (+13 -3) 📝 `packages/hoppscotch-common/src/services/oauth/flows/clientCredentials.ts` (+4 -2) 📝 `packages/hoppscotch-common/src/services/oauth/flows/password.ts` (+4 -2) 📝 `packages/hoppscotch-common/src/services/persistence/__tests__/__mocks__/index.ts` (+5 -5) 📝 `packages/hoppscotch-data/src/collection/index.ts` (+4 -2) 📝 `packages/hoppscotch-data/src/collection/v/3.ts` (+1 -1) ➕ `packages/hoppscotch-data/src/collection/v/4.ts` (+37 -0) 📝 `packages/hoppscotch-data/src/graphql/index.ts` (+6 -3) 📝 `packages/hoppscotch-data/src/graphql/v/3.ts` (+2 -2) 📝 `packages/hoppscotch-data/src/graphql/v/4.ts` (+2 -2) 📝 `packages/hoppscotch-data/src/graphql/v/6.ts` (+1 -1) ➕ `packages/hoppscotch-data/src/graphql/v/7.ts` (+49 -0) 📝 `packages/hoppscotch-data/src/rest/index.ts` (+17 -12) ➕ `packages/hoppscotch-data/src/rest/v/8.ts` (+79 -0) 📝 `packages/hoppscotch-selfhost-web/src/platform/collections/collections.platform.ts` (+4 -4) </details> ### 📄 Description **Changes** * Makes client_secret optional for `clientCredentials` and `password` oauth flows. * Some schemas were imported with the latest version of dependent schemas instead of the one compatible with them. This PR fixes those imports to point to the correct schemas. * Update the collection schema to use the updated auth schemas * Test suite updates accounting for version bumps at the schema level. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>