[PR #3377] [MERGED] refactor: removed all instances of rejectOnNotFound in prisma queries #4363

Closed
opened 2026-03-17 01:54:22 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3377
Author: @balub
Created: 9/21/2023
Status: Merged
Merged: 10/16/2023
Merged by: @balub

Base: release/2023.8.3Head: refactor/pre-prisma-bump-setup


📝 Commits (3)

  • 07c8417 chore: removed rejectOnNotFound property from prisma query in team-enviroment method
  • 685d810 chore: fixed issues with test cases in team-environment module
  • 13393e9 chore: changed target of hoppscotch-old-backend service back to prod

📊 Changes

2 files changed (+6 additions, -5 deletions)

View changed files

📝 packages/hoppscotch-backend/src/team-environments/team-environments.service.spec.ts (+5 -3)
📝 packages/hoppscotch-backend/src/team-environments/team-environments.service.ts (+1 -2)

📄 Description

Closes HBE-264

Description

In this PR, we remove all known instances of rejectOnNotFound parameter in the Prisma queries using it, this is in order to prepare for the Prisma dependency bump.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Additional Information

none


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3377 **Author:** [@balub](https://github.com/balub) **Created:** 9/21/2023 **Status:** ✅ Merged **Merged:** 10/16/2023 **Merged by:** [@balub](https://github.com/balub) **Base:** `release/2023.8.3` ← **Head:** `refactor/pre-prisma-bump-setup` --- ### 📝 Commits (3) - [`07c8417`](https://github.com/hoppscotch/hoppscotch/commit/07c841796aa3d010df7c686a6c68ab15a97c289c) chore: removed rejectOnNotFound property from prisma query in team-enviroment method - [`685d810`](https://github.com/hoppscotch/hoppscotch/commit/685d8105e491bb959b0d470f1d6d69422312b987) chore: fixed issues with test cases in team-environment module - [`13393e9`](https://github.com/hoppscotch/hoppscotch/commit/13393e934680309090fb8080ccca59eadb1235cc) chore: changed target of hoppscotch-old-backend service back to prod ### 📊 Changes **2 files changed** (+6 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-backend/src/team-environments/team-environments.service.spec.ts` (+5 -3) 📝 `packages/hoppscotch-backend/src/team-environments/team-environments.service.ts` (+1 -2) </details> ### 📄 Description <!-- Thanks for creating this pull request 🤗 Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one. --> <!-- If this pull request closes an issue, please mention the issue number below --> Closes HBE-264 ### Description <!-- Add a brief description of the pull request --> In this PR, we remove all known instances of `rejectOnNotFound` parameter in the Prisma queries using it, this is in order to prepare for the Prisma dependency bump. <!-- You can also choose to add a list of changes and if they have been completed or not by using the markdown to-do list syntax - [ ] Not Completed - [x] Completed --> ### Checks <!-- Make sure your pull request passes the CI checks and do check the following fields as needed - --> - [x] My pull request adheres to the code style of this project - [x] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed ### Additional Information none --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 01:54:22 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4363
No description provided.