[GH-ISSUE #1497] Address bar URL params do not update as expected #476

Closed
opened 2026-03-16 15:35:09 +03:00 by kerem · 5 comments
Owner

Originally created by @nelsontky on GitHub (Feb 19, 2021).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/1497

Describe the bug
POST parameters do not update the URL params in the address bar as expected

To Reproduce
Steps to reproduce the behavior:

  1. Create a new POST request.
  2. Add a new parameter to the request body. (Non raw request body)
  3. Set the key to some text.
  4. Click on the value input field.
  5. The address bar URL parameter does not update.
  6. Type something in the param value input field.
  7. The address bar URL finally updates.

Expected behavior
The address bar URL parameter should have updated to reflect the new key in step 5.

Video
https://user-images.githubusercontent.com/7272103/108542861-3e387580-731f-11eb-9bae-ef2b747586d2.mp4

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Chrome
  • Version: Latest

Additional context
I could work on this too!

Originally created by @nelsontky on GitHub (Feb 19, 2021). Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/1497 **Describe the bug** `POST` parameters do not update the URL params in the address bar as expected **To Reproduce** Steps to reproduce the behavior: 1. Create a new `POST` request. 2. Add a new parameter to the request body. (Non raw request body) 3. Set the key to some text. 4. Click on the value input field. 5. The address bar URL parameter does not update. 6. Type something in the param value input field. 7. The address bar URL finally updates. **Expected behavior** The address bar URL parameter should have updated to reflect the new key in step 5. **Video** https://user-images.githubusercontent.com/7272103/108542861-3e387580-731f-11eb-9bae-ef2b747586d2.mp4 **Desktop (please complete the following information):** - OS: Windows - Browser: Chrome - Version: Latest **Additional context** I could work on this too!
kerem 2026-03-16 15:35:09 +03:00
Author
Owner

@LeoMartinDev commented on GitHub (Mar 2, 2021):

I'll take a look

<!-- gh-comment-id:788865598 --> @LeoMartinDev commented on GitHub (Mar 2, 2021): I'll take a look
Author
Owner

@LeoMartinDev commented on GitHub (Mar 2, 2021):

Ok well, this code is super hard to read and there is too many entry points to the setRouteQueryState function (and a watcher) so I'm having a hard time fixing this issue. Maybe someone with more experience on this part of the project will be able to find what's wrong 💪

<!-- gh-comment-id:789090845 --> @LeoMartinDev commented on GitHub (Mar 2, 2021): Ok well, this code is super hard to read and there is too many entry points to the `setRouteQueryState` function (and a watcher) so I'm having a hard time fixing this issue. Maybe someone with more experience on this part of the project will be able to find what's wrong 💪
Author
Owner

@nelsontky commented on GitHub (Mar 2, 2021):

Ok well, this code is super hard to read and there is too many entry points to the setRouteQueryState function (and a watcher) so I'm having a hard time fixing this issue. Maybe someone with more experience on this code will be able to find what's wrong 💪

Ok I can probably can have a go at it tomorrow!

<!-- gh-comment-id:789099570 --> @nelsontky commented on GitHub (Mar 2, 2021): > Ok well, this code is super hard to read and there is too many entry points to the `setRouteQueryState` function (and a watcher) so I'm having a hard time fixing this issue. Maybe someone with more experience on this code will be able to find what's wrong 💪 Ok I can probably can have a go at it tomorrow!
Author
Owner

@JayceDugan commented on GitHub (Mar 16, 2021):

After reviewing the existing description, discussion and having a brief inspection, I do not believe there is an issue here as there may have been a slight misunderstanding with expectations that body parameters operate the same as query parameters in a HTTP request.

Request body parameters do not get appended to a URL in a HTTP request and are instead transmitted immediately after request header under the body options key.

Request query parameters are a set of parameters appended to the end of a URL which appears to be the expected outcome described by this issue.

The existing functionality of request body parameters and request query parameters both appear to be operating relatively as expected (I found a separate issue with request query parameters.).

Request body parameters are attached to the request body, and creating a new GET request and applying query parameters results in the parameters being appended to the request URL. (Though they are not appended correctly but that is a separate issue and requires a different issue write up.)

@nelsontky @LeoMartinDev

<!-- gh-comment-id:800196906 --> @JayceDugan commented on GitHub (Mar 16, 2021): After reviewing the existing description, discussion and having a brief inspection, I do not believe there is an issue here as there may have been a slight misunderstanding with expectations that `body parameters` operate the same as `query parameters` in a HTTP request. `Request body parameters` do **not** get appended to a URL in a HTTP request and are instead transmitted immediately after request header under the `body` options key. `Request query parameters` are a set of parameters appended to the end of a URL which appears to be the expected outcome described by this issue. The existing functionality of `request body parameters` and `request query parameters` both appear to be operating relatively as expected (I found a separate issue with request query parameters.). Request body parameters are attached to the `request body`, and creating a new `GET` request and applying `query parameters` results in the parameters being appended to the request URL. (Though they are not appended correctly but that is a separate issue and requires a different issue write up.) @nelsontky @LeoMartinDev
Author
Owner

@liyasthomas commented on GitHub (Apr 13, 2021):

@nelsontky I can't reproduce this issue in hoppscotch.io anymore. Can you verify this error exists?

<!-- gh-comment-id:818820390 --> @liyasthomas commented on GitHub (Apr 13, 2021): @nelsontky I can't reproduce this issue in [hoppscotch.io](https://hoppscotch.io) anymore. Can you verify this error exists?
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#476
No description provided.