mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[GH-ISSUE #1497] Address bar URL params do not update as expected #476
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#476
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @nelsontky on GitHub (Feb 19, 2021).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/1497
Describe the bug
POSTparameters do not update the URL params in the address bar as expectedTo Reproduce
Steps to reproduce the behavior:
POSTrequest.Expected behavior
The address bar URL parameter should have updated to reflect the new key in step 5.
Video
https://user-images.githubusercontent.com/7272103/108542861-3e387580-731f-11eb-9bae-ef2b747586d2.mp4
Desktop (please complete the following information):
Additional context
I could work on this too!
@LeoMartinDev commented on GitHub (Mar 2, 2021):
I'll take a look
@LeoMartinDev commented on GitHub (Mar 2, 2021):
Ok well, this code is super hard to read and there is too many entry points to the
setRouteQueryStatefunction (and a watcher) so I'm having a hard time fixing this issue. Maybe someone with more experience on this part of the project will be able to find what's wrong 💪@nelsontky commented on GitHub (Mar 2, 2021):
Ok I can probably can have a go at it tomorrow!
@JayceDugan commented on GitHub (Mar 16, 2021):
After reviewing the existing description, discussion and having a brief inspection, I do not believe there is an issue here as there may have been a slight misunderstanding with expectations that
body parametersoperate the same asquery parametersin a HTTP request.Request body parametersdo not get appended to a URL in a HTTP request and are instead transmitted immediately after request header under thebodyoptions key.Request query parametersare a set of parameters appended to the end of a URL which appears to be the expected outcome described by this issue.The existing functionality of
request body parametersandrequest query parametersboth appear to be operating relatively as expected (I found a separate issue with request query parameters.).Request body parameters are attached to the
request body, and creating a newGETrequest and applyingquery parametersresults in the parameters being appended to the request URL. (Though they are not appended correctly but that is a separate issue and requires a different issue write up.)@nelsontky @LeoMartinDev
@liyasthomas commented on GitHub (Apr 13, 2021):
@nelsontky I can't reproduce this issue in hoppscotch.io anymore. Can you verify this error exists?