[PR #4329] [MERGED] feat(filename): added filename in download functional #4752

New issue

Closed

opened 2026-03-17 02:15:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:15:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4329
Author: @shipko
Created: 9/5/2024
Status: ✅ Merged
Merged: 9/19/2024
Merged by: @AndrewBastin

Base: patch ← Head: file-with-name

📝 Commits (4)

d7fbee6 feat(filename): add filename in download functional
45b9a62 feat(filename): add i18n
b826143 feat(filename): remove download feature for import curl component
50684bc chore: add graphql response filename locale

📊 Changes

15 files changed (+56 additions, -46 deletions)

View changed files

📝 packages/hoppscotch-common/locales/en.json (+7 -0)
📝 packages/hoppscotch-common/src/components/cookies/EditCookie.vue (+3 -2)
📝 packages/hoppscotch-common/src/components/graphql/Response.vue (+2 -1)
📝 packages/hoppscotch-common/src/components/http/Codegen.vue (+7 -1)
📝 packages/hoppscotch-common/src/components/http/ImportCurl.vue (+1 -11)
📝 packages/hoppscotch-common/src/components/lenses/renderers/AudioLensRenderer.vue (+4 -1)
📝 packages/hoppscotch-common/src/components/lenses/renderers/HTMLLensRenderer.vue (+4 -1)
📝 packages/hoppscotch-common/src/components/lenses/renderers/ImageLensRenderer.vue (+4 -1)
📝 packages/hoppscotch-common/src/components/lenses/renderers/JSONLensRenderer.vue (+4 -1)
📝 packages/hoppscotch-common/src/components/lenses/renderers/PDFLensRenderer.vue (+4 -1)
📝 packages/hoppscotch-common/src/components/lenses/renderers/RawLensRenderer.vue (+4 -1)
📝 packages/hoppscotch-common/src/components/lenses/renderers/VideoLensRenderer.vue (+4 -1)
📝 packages/hoppscotch-common/src/components/lenses/renderers/XMLLensRenderer.vue (+4 -1)
📝 packages/hoppscotch-common/src/components/realtime/LogEntry.vue (+2 -1)
📝 packages/hoppscotch-common/src/composables/lens-actions.ts (+2 -22)

📄 Description

Closes #4265

What's changed

Added name for file in all useDownloadResponse methods

Not Completed
Completed

Notes to reviewers

Maybe we need to move file name in locale files?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4329 **Author:** [@shipko](https://github.com/shipko) **Created:** 9/5/2024 **Status:** ✅ Merged **Merged:** 9/19/2024 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `patch` ← **Head:** `file-with-name` --- ### 📝 Commits (4) - [`d7fbee6`](https://github.com/hoppscotch/hoppscotch/commit/d7fbee6ee4a1383238d6497b722bf2238c67a538) feat(filename): add filename in download functional - [`45b9a62`](https://github.com/hoppscotch/hoppscotch/commit/45b9a6222421e71e4311c0dae18fa0eef3343c01) feat(filename): add i18n - [`b826143`](https://github.com/hoppscotch/hoppscotch/commit/b826143833ac2a59448b2e644175714b6163972a) feat(filename): remove download feature for import curl component - [`50684bc`](https://github.com/hoppscotch/hoppscotch/commit/50684bcc6e6e26abaf19ecffcbb5f95b8a019c2d) chore: add graphql response filename locale ### 📊 Changes **15 files changed** (+56 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/locales/en.json` (+7 -0) 📝 `packages/hoppscotch-common/src/components/cookies/EditCookie.vue` (+3 -2) 📝 `packages/hoppscotch-common/src/components/graphql/Response.vue` (+2 -1) 📝 `packages/hoppscotch-common/src/components/http/Codegen.vue` (+7 -1) 📝 `packages/hoppscotch-common/src/components/http/ImportCurl.vue` (+1 -11) 📝 `packages/hoppscotch-common/src/components/lenses/renderers/AudioLensRenderer.vue` (+4 -1) 📝 `packages/hoppscotch-common/src/components/lenses/renderers/HTMLLensRenderer.vue` (+4 -1) 📝 `packages/hoppscotch-common/src/components/lenses/renderers/ImageLensRenderer.vue` (+4 -1) 📝 `packages/hoppscotch-common/src/components/lenses/renderers/JSONLensRenderer.vue` (+4 -1) 📝 `packages/hoppscotch-common/src/components/lenses/renderers/PDFLensRenderer.vue` (+4 -1) 📝 `packages/hoppscotch-common/src/components/lenses/renderers/RawLensRenderer.vue` (+4 -1) 📝 `packages/hoppscotch-common/src/components/lenses/renderers/VideoLensRenderer.vue` (+4 -1) 📝 `packages/hoppscotch-common/src/components/lenses/renderers/XMLLensRenderer.vue` (+4 -1) 📝 `packages/hoppscotch-common/src/components/realtime/LogEntry.vue` (+2 -1) 📝 `packages/hoppscotch-common/src/composables/lens-actions.ts` (+2 -22) </details> ### 📄 Description Closes #4265 ### What's changed Added name for file in all useDownloadResponse methods - [ ] Not Completed - [x] Completed ### Notes to reviewers Maybe we need to move file name in locale files? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>