[PR #3163] [MERGED] fix: keybinding modifier issue #4265

New issue

Closed

opened 2026-03-17 01:48:55 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:48:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3163
Author: @anwarulislam
Created: 6/27/2023
Status: ✅ Merged
Merged: 7/17/2023
Merged by: @AndrewBastin

Base: release/2023.4.8 ← Head: fix/keybinding-modifier

📝 Commits (3)

29423ee fix: keybinding modifier issue
6eb1c97 fix: spelling
36d14c2 chore: added ternary operator to compare empty string

📊 Changes

1 file changed (+18 additions, -11 deletions)

View changed files

📝 packages/hoppscotch-common/src/helpers/keybindings.ts (+18 -11)

📄 Description

Before

Prioritization of key bindings was preventing to run browser's default shortcuts
Only available modifier was type ModifierKeys = "ctrl" | "alt" | "ctrl-shift" | "alt-shift"

After

Running browser's default shortcuts issue fixed
Extended modifier to type ModifierKeys = "ctrl" | "alt" | "ctrl-shift" | "alt-shift" | "ctrl-alt" | "ctrl-alt-shift"

Walkthrough

Extend ModifierKeys type to support more keybindings (link)
Refactor getActiveModifier function to use object and filter (link)

Closes HFE-116

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3163 **Author:** [@anwarulislam](https://github.com/anwarulislam) **Created:** 6/27/2023 **Status:** ✅ Merged **Merged:** 7/17/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.4.8` ← **Head:** `fix/keybinding-modifier` --- ### 📝 Commits (3) - [`29423ee`](https://github.com/hoppscotch/hoppscotch/commit/29423eeb718f73599867ef760b0e421e3a5ff3cd) fix: keybinding modifier issue - [`6eb1c97`](https://github.com/hoppscotch/hoppscotch/commit/6eb1c97cb6c14e9cc8accd1463e305bc236e2136) fix: spelling - [`36d14c2`](https://github.com/hoppscotch/hoppscotch/commit/36d14c24fb59be47531fa45158f7c6c5e80eac47) chore: added ternary operator to compare empty string ### 📊 Changes **1 file changed** (+18 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/helpers/keybindings.ts` (+18 -11) </details> ### 📄 Description ## Before - Prioritization of key bindings was preventing to run browser's default shortcuts - Only available modifier was `type ModifierKeys = "ctrl" | "alt" | "ctrl-shift" | "alt-shift"` ## After - Running browser's default shortcuts issue fixed - Extended modifier to `type ModifierKeys = "ctrl" | "alt" | "ctrl-shift" | "alt-shift" | "ctrl-alt" | "ctrl-alt-shift"` ### Walkthrough * Extend `ModifierKeys` type to support more keybindings ([link](https://github.com/hoppscotch/hoppscotch/pull/3163/files?diff=unified&w=0#diff-1739024c7f2b818baf3371ad86dfd3f41e18acfc2da76778f3d545832beb4de6L17-R23)) * Refactor `getActiveModifier` function to use object and filter ([link](https://github.com/hoppscotch/hoppscotch/pull/3163/files?diff=unified&w=0#diff-1739024c7f2b818baf3371ad86dfd3f41e18acfc2da76778f3d545832beb4de6L146-R165)) Closes HFE-116 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>