[PR #4279] [MERGED] fix: issues with port binding in different container runtimes #4735

New issue

Closed

opened 2026-03-17 02:14:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:14:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4279
Author: @AndrewBastin
Created: 8/19/2024
Status: ✅ Merged
Merged: 8/21/2024
Merged by: @AndrewBastin

Base: patch ← Head: fix/port-issues

📝 Commits (4)

895b7d3 chore: disable caddy admin endpoints
b602de5 chore: disable caddy persit_config option
73a1887 chore: format caddyfile using caddy fmt
e49958e chore: remove user setup from containers

📊 Changes

9 files changed (+57 additions, -32 deletions)

View changed files

📝 aio-multiport-setup.Caddyfile (+5 -0)
📝 aio-subpath-access.Caddyfile (+5 -0)
📝 packages/hoppscotch-backend/backend.Caddyfile (+5 -0)
📝 packages/hoppscotch-selfhost-web/Caddyfile (+5 -0)
📝 packages/hoppscotch-selfhost-web/selfhost-web.Caddyfile (+5 -0)
📝 packages/hoppscotch-sh-admin/Caddyfile (+5 -0)
📝 packages/hoppscotch-sh-admin/sh-admin-multiport-setup.Caddyfile (+5 -0)
📝 packages/hoppscotch-sh-admin/sh-admin-subpath-access.Caddyfile (+5 -0)
📝 prod.Dockerfile (+17 -32)

📄 Description

Closes #4257 #4264

This PR aims to fix the issues caused due to the introduction of non-root users in the selfhost containers introduced in #4233. The removal of the root user from the container execution scope is still something we will try to pursue later on once we have more understanding of the implications.

What's changed

Revert the docker commands to make a non-root user that executes the container and returns it back to the default.
Remove Caddy Admin Endpoint (this endpoint is not exposed so shouldn't affect anyways) and config persistence

Notes to reviewers

N/A

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4279 **Author:** [@AndrewBastin](https://github.com/AndrewBastin) **Created:** 8/19/2024 **Status:** ✅ Merged **Merged:** 8/21/2024 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `patch` ← **Head:** `fix/port-issues` --- ### 📝 Commits (4) - [`895b7d3`](https://github.com/hoppscotch/hoppscotch/commit/895b7d34b4ee612325f1522bc26b5da6c61eb11b) chore: disable caddy admin endpoints - [`b602de5`](https://github.com/hoppscotch/hoppscotch/commit/b602de5c42400ff6dc618f35f545462426646eba) chore: disable caddy persit_config option - [`73a1887`](https://github.com/hoppscotch/hoppscotch/commit/73a1887f619ef829535d9d5977a6384115d20a4c) chore: format caddyfile using caddy fmt - [`e49958e`](https://github.com/hoppscotch/hoppscotch/commit/e49958ef5b3fbe70d0c01268ee26c037ad04bbf3) chore: remove user setup from containers ### 📊 Changes **9 files changed** (+57 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `aio-multiport-setup.Caddyfile` (+5 -0) 📝 `aio-subpath-access.Caddyfile` (+5 -0) 📝 `packages/hoppscotch-backend/backend.Caddyfile` (+5 -0) 📝 `packages/hoppscotch-selfhost-web/Caddyfile` (+5 -0) 📝 `packages/hoppscotch-selfhost-web/selfhost-web.Caddyfile` (+5 -0) 📝 `packages/hoppscotch-sh-admin/Caddyfile` (+5 -0) 📝 `packages/hoppscotch-sh-admin/sh-admin-multiport-setup.Caddyfile` (+5 -0) 📝 `packages/hoppscotch-sh-admin/sh-admin-subpath-access.Caddyfile` (+5 -0) 📝 `prod.Dockerfile` (+17 -32) </details> ### 📄 Description Closes #4257 #4264 This PR aims to fix the issues caused due to the introduction of non-root users in the selfhost containers introduced in #4233. The removal of the root user from the container execution scope is still something we will try to pursue later on once we have more understanding of the implications. ### What's changed 1. Revert the docker commands to make a non-root user that executes the container and returns it back to the default. 2. Remove Caddy Admin Endpoint (this endpoint is not exposed so shouldn't affect anyways) and config persistence ### Notes to reviewers N/A --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>