[PR #3115] [MERGED] fix: collection request name edit issue #4233

New issue

Closed

opened 2026-03-17 01:47:17 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:47:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3115
Author: @anwarulislam
Created: 6/5/2023
Status: ✅ Merged
Merged: 6/9/2023
Merged by: @AndrewBastin

Base: release/2023.4.6 ← Head: fix/collection-request-name-edit

📝 Commits (10+)

54490f0 fix: collection request name edit issue
e70a7ee chore: invoke action to save request
757be07 chore: save only when savecontext is available
057b2f8 fix: default name appear on save modal
1687e77 chore: lint
16a9557 fix: just-in-time component initiation
e002c37 chore: added nullish coalescing operator
fc97f84 feat: added toast to confirm saving
238faca fix: set dirty as false when saving from coll
413671c refactor: revert toast

📊 Changes

3 files changed (+13 additions, -3 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/collections/index.vue (+10 -2)
📝 packages/hoppscotch-common/src/components/http/Request.vue (+1 -0)
📝 packages/hoppscotch-common/src/pages/index.vue (+2 -1)

📄 Description

Tests

Personal workspace

Editing and saving requests from personal workspace > collection section - changes should be directly saved, no dirty indicator
Editing and saving request from personal workspace > double click the tab name - request should be dirty with unsaved changes indicator
Editing and saving new requests from personal workspace > new request (click on the new tab +)" - request should be dirty with unsaved changes indicator

Team workspace

Editing and saving requests from team workspace > collection section - changes should be directly saved, no dirty indicator
Editing and saving request from team workspace > double click the tab name - request should be dirty with unsaved changes indicator
Editing and saving new requests from team workspace > new request (click on the new tab +)" - request should be dirty with unsaved changes indicator

Behaviours

Dirty indicator behavior on all above cases
Manual save action behavior on all above cases

`🤖 Generated by Copilot at c343374`

Summary

✨🐛♻️

Simplify request name editing in collections modal. Use v-model and editingRequestName ref to bind data and UI elements in collections/index.vue.

We're editing request names with ease
Using v-model and a ref
No more messy data flow to tease
Just a modal dialog that's smooth and def

Walkthrough

Simplify data binding for editing request name in modal dialog (link, link, link, link)

Closes HFE-75
Closes #3114

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3115 **Author:** [@anwarulislam](https://github.com/anwarulislam) **Created:** 6/5/2023 **Status:** ✅ Merged **Merged:** 6/9/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.4.6` ← **Head:** `fix/collection-request-name-edit` --- ### 📝 Commits (10+) - [`54490f0`](https://github.com/hoppscotch/hoppscotch/commit/54490f01db97b58b3ef3ad66fdb5610cb6a5fef0) fix: collection request name edit issue - [`e70a7ee`](https://github.com/hoppscotch/hoppscotch/commit/e70a7ee17de7215b7bb64ce4cef3faa8b1b7e7f2) chore: invoke action to save request - [`757be07`](https://github.com/hoppscotch/hoppscotch/commit/757be07dcb0673f5ad408c2949355bf817751845) chore: save only when savecontext is available - [`057b2f8`](https://github.com/hoppscotch/hoppscotch/commit/057b2f8259067dea3ae219af848127f8c712c2ba) fix: default name appear on save modal - [`1687e77`](https://github.com/hoppscotch/hoppscotch/commit/1687e77d7d58c8707dd41a8b1570f266898a054d) chore: lint - [`16a9557`](https://github.com/hoppscotch/hoppscotch/commit/16a95576e5b91cd0a745468e3ac8817920f76b08) fix: just-in-time component initiation - [`e002c37`](https://github.com/hoppscotch/hoppscotch/commit/e002c379d9a80e002d8c4d6a6fa9be72ee807757) chore: added nullish coalescing operator - [`fc97f84`](https://github.com/hoppscotch/hoppscotch/commit/fc97f841803ea1ef4376af83b91f98484caf20f7) feat: added toast to confirm saving - [`238faca`](https://github.com/hoppscotch/hoppscotch/commit/238faca2b39008e9a795b00b470bba3c90d67f0b) fix: set dirty as false when saving from coll - [`413671c`](https://github.com/hoppscotch/hoppscotch/commit/413671c672d4f26c4b17c792e0be9e4771a3a47b) refactor: revert toast ### 📊 Changes **3 files changed** (+13 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/collections/index.vue` (+10 -2) 📝 `packages/hoppscotch-common/src/components/http/Request.vue` (+1 -0) 📝 `packages/hoppscotch-common/src/pages/index.vue` (+2 -1) </details> ### 📄 Description ### Tests **Personal workspace** - [x] Editing and saving requests from personal workspace > collection section - **changes should be directly saved, no dirty indicator** - [x] Editing and saving request from personal workspace > double click the tab name - **request should be dirty with unsaved changes indicator** - [x] Editing and saving new requests from personal workspace > new request (click on the new tab +)" - **request should be dirty with unsaved changes indicator** **Team workspace** - [x] Editing and saving requests from team workspace > collection section - **changes should be directly saved, no dirty indicator** - [x] Editing and saving request from team workspace > double click the tab name - **request should be dirty with unsaved changes indicator** - [x] Editing and saving new requests from team workspace > new request (click on the new tab +)" - **request should be dirty with unsaved changes indicator** **Behaviours** - [x] Dirty indicator behavior on all above cases - [x] Manual save action behavior on all above cases  ### <samp>🤖 Generated by Copilot at c343374</samp> ### Summary ✨🐛♻️  Simplify request name editing in collections modal. Use `v-model` and `editingRequestName` ref to bind data and UI elements in `collections/index.vue`. > _We're editing request names with ease_ > _Using `v-model` and a `ref`_ > _No more messy data flow to tease_ > _Just a modal dialog that's smooth and def_ ### Walkthrough * Simplify data binding for editing request name in modal dialog ([link](https://github.com/hoppscotch/hoppscotch/pull/3115/files?diff=unified&w=0#diff-bea4d3e00e3d1167aa2228f3ce3d9a582dc3a006e0753c3806c6e8f1ec0d4080L129-R129), [link](https://github.com/hoppscotch/hoppscotch/pull/3115/files?diff=unified&w=0#diff-bea4d3e00e3d1167aa2228f3ce3d9a582dc3a006e0753c3806c6e8f1ec0d4080R291), [link](https://github.com/hoppscotch/hoppscotch/pull/3115/files?diff=unified&w=0#diff-bea4d3e00e3d1167aa2228f3ce3d9a582dc3a006e0753c3806c6e8f1ec0d4080R864), [link](https://github.com/hoppscotch/hoppscotch/pull/3115/files?diff=unified&w=0#diff-bea4d3e00e3d1167aa2228f3ce3d9a582dc3a006e0753c3806c6e8f1ec0d4080R882)) Closes HFE-75 Closes #3114 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>