[PR #4210] [MERGED] fix: auth bug when value is a secret environment #4705

New issue

Closed

opened 2026-03-17 02:12:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:12:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4210
Author: @nivedin
Created: 7/24/2024
Status: ✅ Merged
Merged: 7/27/2024
Merged by: @jamesgeorge007

Base: next ← Head: fix/auth-secret-variable-bug

📝 Commits (2)

fa205e6 fix: auth bug when value is secret env
6a99dba chore: resolve type errors

📊 Changes

3 files changed (+54 additions, -13 deletions)

View changed files

📝 packages/hoppscotch-common/package.json (+2 -1)
📝 packages/hoppscotch-common/src/helpers/utils/EffectiveURL.ts (+49 -12)
📝 pnpm-lock.yaml (+3 -0)

📄 Description

Closes #4208

This PR fixes the issue in auth where the secret-variable didn't get resolved while sending request.

What's changed

The getComputedAuthHeaders function in EffectiveURL.ts now have showKeyIfSecret param where the parseTemplateString returns the secret-env value rather than the key.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4210 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 7/24/2024 **Status:** ✅ Merged **Merged:** 7/27/2024 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `next` ← **Head:** `fix/auth-secret-variable-bug` --- ### 📝 Commits (2) - [`fa205e6`](https://github.com/hoppscotch/hoppscotch/commit/fa205e69f30e979c41f8e8084538d0ffe421dc90) fix: auth bug when value is secret env - [`6a99dba`](https://github.com/hoppscotch/hoppscotch/commit/6a99dba205758996000d6b1421fda76fb77ad402) chore: resolve type errors ### 📊 Changes **3 files changed** (+54 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/package.json` (+2 -1) 📝 `packages/hoppscotch-common/src/helpers/utils/EffectiveURL.ts` (+49 -12) 📝 `pnpm-lock.yaml` (+3 -0) </details> ### 📄 Description Closes #4208 This PR fixes the issue in auth where the secret-variable didn't get resolved while sending request. ### What's changed The `getComputedAuthHeaders` function in EffectiveURL.ts now have `showKeyIfSecret` param where the `parseTemplateString` returns the secret-env value rather than the key. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>