[PR #3059] [MERGED] fix: set team environment from test #4208

Closed
opened 2026-03-17 01:45:55 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3059
Author: @nivedin
Created: 5/16/2023
Status: Merged
Merged: 5/30/2023
Merged by: @AndrewBastin

Base: release/2023.4.4Head: fix/team-env-set-test


📝 Commits (2)

📊 Changes

3 files changed (+37 additions, -12 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/environments/my/Details.vue (+2 -2)
📝 packages/hoppscotch-common/src/components/environments/teams/Details.vue (+17 -7)
📝 packages/hoppscotch-common/src/components/http/TestResult.vue (+18 -3)

📄 Description

Closes HFE-54

Description

This PR adds the option to set an environment from the test and save it as a team environment if the team workspace is selected.

Before

When using the test pw.env.set("variable", "value"); saves the environment to the 'My Environments' or to the 'Global' even the current workspace is selected as team.

After

Now when using the pw.env.set("variable", "value"); sets the environment automatically to the selected team environment and personal environments respectively checking the current workspace status.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3059 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 5/16/2023 **Status:** ✅ Merged **Merged:** 5/30/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.4.4` ← **Head:** `fix/team-env-set-test` --- ### 📝 Commits (2) - [`297c2f1`](https://github.com/hoppscotch/hoppscotch/commit/297c2f1be3e5379334305dafcf230040cf37fb4b) fix: set team env from test - [`694d371`](https://github.com/hoppscotch/hoppscotch/commit/694d371887ecd69c56bce459783ef228ae6e9e46) fix: type isssue ### 📊 Changes **3 files changed** (+37 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/environments/my/Details.vue` (+2 -2) 📝 `packages/hoppscotch-common/src/components/environments/teams/Details.vue` (+17 -7) 📝 `packages/hoppscotch-common/src/components/http/TestResult.vue` (+18 -3) </details> ### 📄 Description Closes HFE-54 ### Description This PR adds the option to set an environment from the test and save it as a team environment if the team workspace is selected. #### Before When using the test `pw.env.set("variable", "value");` saves the environment to the 'My Environments' or to the 'Global' even the current workspace is selected as team. #### After Now when using the `pw.env.set("variable", "value");` sets the environment automatically to the selected team environment and personal environments respectively checking the current workspace status. ### Checks - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [X] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 01:45:55 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4208
No description provided.