[PR #4146] [MERGED] HSB-452 hotfix: storing user in local variable #4677

New issue

Closed

opened 2026-03-17 02:11:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:11:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4146
Author: @mirarifhasan
Created: 6/25/2024
Status: ✅ Merged
Merged: 6/25/2024
Merged by: @AndrewBastin

Base: next ← Head: hotfix/user-last-active-interceptor

📝 Commits (2)

61be3dd fix: storing user in local variable
f22cd92 chore: update pnpm-lock.yaml

📊 Changes

2 files changed (+5762 additions, -5431 deletions)

View changed files

📝 packages/hoppscotch-backend/src/interceptors/user-last-active-on.interceptor.ts (+10 -12)
📝 pnpm-lock.yaml (+5752 -5419)

📄 Description

Closes HSB-452

What's changed

In user-last-login.interceptor.ts, we previously used a class level global variable user. If multiple users send requests, there is a chance, the older user's value can be replaced by the new user's object.

In this PR, we used a local variable to mitigate this issue.

Notes to reviewers

Nil

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4146 **Author:** [@mirarifhasan](https://github.com/mirarifhasan) **Created:** 6/25/2024 **Status:** ✅ Merged **Merged:** 6/25/2024 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `next` ← **Head:** `hotfix/user-last-active-interceptor` --- ### 📝 Commits (2) - [`61be3dd`](https://github.com/hoppscotch/hoppscotch/commit/61be3ddff1ba8085c42d5e9fd0c4425bf574cdb6) fix: storing user in local variable - [`f22cd92`](https://github.com/hoppscotch/hoppscotch/commit/f22cd927cfc563932ff029a93a88a4d09a9acec7) chore: update pnpm-lock.yaml ### 📊 Changes **2 files changed** (+5762 additions, -5431 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-backend/src/interceptors/user-last-active-on.interceptor.ts` (+10 -12) 📝 `pnpm-lock.yaml` (+5752 -5419) </details> ### 📄 Description    Closes HSB-452  ### What's changed  In `user-last-login.interceptor.ts`, we previously used a class level global variable `user`. If multiple users send requests, there is a chance, the older user's value can be replaced by the new user's object. In this PR, we used a local variable to mitigate this issue.  ### Notes to reviewers  Nil --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>