[PR #2947] [MERGED] refactor: store changes for collections #4146

New issue

Closed

opened 2026-03-17 01:42:38 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:42:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/2947
Author: @amk-dev
Created: 3/13/2023
Status: ✅ Merged
Merged: 3/14/2023
Merged by: @AndrewBastin

Base: staging ← Head: chore/store-changes-for-collections

📝 Commits (1)

28c5678 chore: make edit collection take partial collection as parameter

📊 Changes

1 file changed (+9 additions, -6 deletions)

View changed files

📝 packages/hoppscotch-common/src/newstore/collections.ts (+9 -6)

📄 Description

Before

You needed the entire collection to call editCollection. This was a limitation when handling UserCollectionEdited subscription, because we don't have access to the entire collection. Also the only thing we updated was the collection name.
navigateToFolderWithIndexPath was not exported, but were required in the sync layer

After

editCollection store dispatcher takes a partial collection as an argument, instead of an entire collection
navigateToFolderWithIndexPath is exported

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/2947 **Author:** [@amk-dev](https://github.com/amk-dev) **Created:** 3/13/2023 **Status:** ✅ Merged **Merged:** 3/14/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `staging` ← **Head:** `chore/store-changes-for-collections` --- ### 📝 Commits (1) - [`28c5678`](https://github.com/hoppscotch/hoppscotch/commit/28c567804378a439a0824e543b388e0b2daae054) chore: make edit collection take partial collection as parameter ### 📊 Changes **1 file changed** (+9 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/newstore/collections.ts` (+9 -6) </details> ### 📄 Description **Before** 1. You needed the entire collection to call `editCollection`. This was a limitation when handling `UserCollectionEdited` subscription, because we don't have access to the entire collection. Also the only thing we updated was the collection name. 2. `navigateToFolderWithIndexPath` was not exported, but were required in the sync layer **After** 1. `editCollection` store dispatcher takes a partial collection as an argument, instead of an entire collection 2. `navigateToFolderWithIndexPath` is exported --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>