[PR #3971] [MERGED] refactor(sh-admin): improved handling of server configurations in admin dashboard #4618

New issue

Closed

opened 2026-03-17 02:08:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:08:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3971
Author: @joeljstephen
Created: 4/12/2024
Status: ✅ Merged
Merged: 5/6/2024
Merged by: @jamesgeorge007

Base: release/2024.3.3 ← Head: refactor/dashboard-configs

📝 Commits (10+)

c7afe62 feat: new configs file to abstract types and config definitions
9e0bcec refactor: updated names for config related types and constants
c9f93ae refactor: removed unnecessary fields from configs
cc25763 refactor: updated imports on config related components to use types from configs helper
2a8cf09 refactor: removed unnecessary github fields from config handler
0b010de refactor: reroute to users page only if user is successfully deleted from individual user page
60451d8 refactor: updated imports in server restart and configurations component
ce05abb refactor: new update failure i18n string
cd1c73f refactor: using inline exports for configs export
0d945b9 refactor: new logic to streamline to push and filter configs

📊 Changes

9 files changed (+303 additions, -279 deletions)

View changed files

📝 packages/hoppscotch-sh-admin/locales/en.json (+2 -1)
📝 packages/hoppscotch-sh-admin/src/components/settings/AuthProvider.vue (+4 -4)
📝 packages/hoppscotch-sh-admin/src/components/settings/Configurations.vue (+3 -3)
📝 packages/hoppscotch-sh-admin/src/components/settings/DataSharing.vue (+3 -3)
📝 packages/hoppscotch-sh-admin/src/components/settings/ServerRestart.vue (+4 -3)
📝 packages/hoppscotch-sh-admin/src/components/settings/SmtpConfiguration.vue (+6 -6)
📝 packages/hoppscotch-sh-admin/src/composables/useConfigHandler.ts (+116 -255)
➕ packages/hoppscotch-sh-admin/src/helpers/configs.ts (+160 -0)
📝 packages/hoppscotch-sh-admin/src/pages/users/_id.vue (+5 -4)

📄 Description

Ticket

Closes HFE-479

Description

This PR aims to refactor the handling of server configurations in the admin dashboard.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3971 **Author:** [@joeljstephen](https://github.com/joeljstephen) **Created:** 4/12/2024 **Status:** ✅ Merged **Merged:** 5/6/2024 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `release/2024.3.3` ← **Head:** `refactor/dashboard-configs` --- ### 📝 Commits (10+) - [`c7afe62`](https://github.com/hoppscotch/hoppscotch/commit/c7afe62ded3fbceffeb7015e54d5e621c75d8f2c) feat: new configs file to abstract types and config definitions - [`9e0bcec`](https://github.com/hoppscotch/hoppscotch/commit/9e0bcec256ffd2c19188da3d938d2b7bc5a38404) refactor: updated names for config related types and constants - [`c9f93ae`](https://github.com/hoppscotch/hoppscotch/commit/c9f93ae9a180c8b1d47eb0ca881e4d64b2f4988f) refactor: removed unnecessary fields from configs - [`cc25763`](https://github.com/hoppscotch/hoppscotch/commit/cc257631369be9076d79d5d790e50a6b30562f45) refactor: updated imports on config related components to use types from configs helper - [`2a8cf09`](https://github.com/hoppscotch/hoppscotch/commit/2a8cf0954f05dfb1e217022f9fa5da572fc5a828) refactor: removed unnecessary github fields from config handler - [`0b010de`](https://github.com/hoppscotch/hoppscotch/commit/0b010deca6c732ed23d2781b410b776ec0b83f12) refactor: reroute to users page only if user is successfully deleted from individual user page - [`60451d8`](https://github.com/hoppscotch/hoppscotch/commit/60451d840511e2719b11ca2767ce9ac162560ff9) refactor: updated imports in server restart and configurations component - [`ce05abb`](https://github.com/hoppscotch/hoppscotch/commit/ce05abb568adebeb0f28e3057ddda0f4e26596db) refactor: new update failure i18n string - [`cd1c73f`](https://github.com/hoppscotch/hoppscotch/commit/cd1c73f3e6512179bfb293a4f0dd83a4ae6172de) refactor: using inline exports for configs export - [`0d945b9`](https://github.com/hoppscotch/hoppscotch/commit/0d945b9def7860977629b5bb419a582c6bb43789) refactor: new logic to streamline to push and filter configs ### 📊 Changes **9 files changed** (+303 additions, -279 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-sh-admin/locales/en.json` (+2 -1) 📝 `packages/hoppscotch-sh-admin/src/components/settings/AuthProvider.vue` (+4 -4) 📝 `packages/hoppscotch-sh-admin/src/components/settings/Configurations.vue` (+3 -3) 📝 `packages/hoppscotch-sh-admin/src/components/settings/DataSharing.vue` (+3 -3) 📝 `packages/hoppscotch-sh-admin/src/components/settings/ServerRestart.vue` (+4 -3) 📝 `packages/hoppscotch-sh-admin/src/components/settings/SmtpConfiguration.vue` (+6 -6) 📝 `packages/hoppscotch-sh-admin/src/composables/useConfigHandler.ts` (+116 -255) ➕ `packages/hoppscotch-sh-admin/src/helpers/configs.ts` (+160 -0) 📝 `packages/hoppscotch-sh-admin/src/pages/users/_id.vue` (+5 -4) </details> ### 📄 Description ### Ticket Closes HFE-479 ### Description This PR aims to refactor the handling of server configurations in the admin dashboard. ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>