[PR #2662] [MERGED] fix: find linked account from authentication error and link it #3971

New issue

Closed

opened 2026-03-17 01:32:37 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:32:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/2662
Author: @aitchnyu
Created: 9/14/2022
Status: ✅ Merged
Merged: 10/3/2022
Merged by: @AndrewBastin

Base: main ← Head: fix/fix-account-linking-firebase

📝 Commits (2)

f50d298 fix: find linked account from authentication error and linked it, removed account linking dead code
d1d6c52 chore: a bit of formatting

📊 Changes

2 files changed (+35 additions, -68 deletions)

View changed files

📝 packages/hoppscotch-app/src/components/firebase/Login.vue (+16 -60)
📝 packages/hoppscotch-app/src/helpers/fb/auth.ts (+19 -8)

📄 Description

Description

If an account linking error happens, new logic finds out the account and links it. Dead code related to linking accounts have been deleted.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

Additional Information

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/2662 **Author:** [@aitchnyu](https://github.com/aitchnyu) **Created:** 9/14/2022 **Status:** ✅ Merged **Merged:** 10/3/2022 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `main` ← **Head:** `fix/fix-account-linking-firebase` --- ### 📝 Commits (2) - [`f50d298`](https://github.com/hoppscotch/hoppscotch/commit/f50d2984a1c1d5fddbb3cf76636dcec8c87c7a54) fix: find linked account from authentication error and linked it, removed account linking dead code - [`d1d6c52`](https://github.com/hoppscotch/hoppscotch/commit/d1d6c5221c64420f4cd55c5a848b14703f980dd8) chore: a bit of formatting ### 📊 Changes **2 files changed** (+35 additions, -68 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-app/src/components/firebase/Login.vue` (+16 -60) 📝 `packages/hoppscotch-app/src/helpers/fb/auth.ts` (+19 -8) </details> ### 📄 Description  ### Description  If an account linking error happens, new logic finds out the account and links it. Dead code related to linking accounts have been deleted.  ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed ### Additional Information  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>