[PR #3792] [MERGED] chore: Oauth temporary ux improvements #4529

Closed
opened 2026-03-17 02:03:24 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3792
Author: @amk-dev
Created: 1/30/2024
Status: Merged
Merged: 2/6/2024
Merged by: @AndrewBastin

Base: release/2023.12.4Head: chore/oauth-ux


📝 Commits (3)

  • c23a85a chore: oauth temporary improvements
  • a2d8337 fix: fix old validation statement
  • fc3fb24 refactor: move waiting for extension to the extension interceptor

📊 Changes

3 files changed (+73 additions, -45 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/http/OAuth2Authorization.vue (+22 -6)
📝 packages/hoppscotch-common/src/helpers/oauth.ts (+42 -39)
📝 packages/hoppscotch-common/src/platform/std/interceptors/extension.ts (+9 -0)

📄 Description

Fixes HFE-382

Changes

  1. Disable the OpenID Connect Discovery URL when Authorization/Access Token URLs are present.
  2. Disable Authorization/Access Token URLs when the OpenID Connect Discovery URL is present.
  3. Implement OAuth fetch calls through interceptors.
  4. Fix an if statement that made OpenID Connect discovery URLs mandatory

Note
We will be removing OpenID Connect Discovery URL very soon. this is temporary solution till then.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3792 **Author:** [@amk-dev](https://github.com/amk-dev) **Created:** 1/30/2024 **Status:** ✅ Merged **Merged:** 2/6/2024 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.12.4` ← **Head:** `chore/oauth-ux` --- ### 📝 Commits (3) - [`c23a85a`](https://github.com/hoppscotch/hoppscotch/commit/c23a85a5b7bcd90e28df9d41f32badca8530d95a) chore: oauth temporary improvements - [`a2d8337`](https://github.com/hoppscotch/hoppscotch/commit/a2d83371d8b6a03a846118629030a46f0236a9d8) fix: fix old validation statement - [`fc3fb24`](https://github.com/hoppscotch/hoppscotch/commit/fc3fb2494ccbf3dc3b3dd8a2ca3107bebd033e7b) refactor: move waiting for extension to the extension interceptor ### 📊 Changes **3 files changed** (+73 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/http/OAuth2Authorization.vue` (+22 -6) 📝 `packages/hoppscotch-common/src/helpers/oauth.ts` (+42 -39) 📝 `packages/hoppscotch-common/src/platform/std/interceptors/extension.ts` (+9 -0) </details> ### 📄 Description Fixes HFE-382 **Changes** 1. Disable the OpenID Connect Discovery URL when Authorization/Access Token URLs are present. 2. Disable Authorization/Access Token URLs when the OpenID Connect Discovery URL is present. 3. Implement OAuth fetch calls through interceptors. 4. Fix an if statement that made OpenID Connect discovery URLs mandatory **Note** We will be removing OpenID Connect Discovery URL very soon. this is temporary solution till then. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 02:03:24 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4529
No description provided.