[PR #2410] [MERGED] feat: checks only if not default param #3792

New issue

Closed

opened 2026-03-17 01:22:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:22:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/2410
Author: @moritzmock
Created: 6/11/2022
Status: ✅ Merged
Merged: 6/14/2022
Merged by: @AndrewBastin

Base: main ← Head: check_confirmation

📝 Commits (4)

1aca454 feat: checks only if not default param
7b21848 fix: moved logic
ae15113 Update packages/hoppscotch-app/components/collections/my/Request.vue
9e1b8d7 fix: added commented and fixed typo

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 packages/hoppscotch-app/components/collections/my/Request.vue (+4 -0)

📄 Description

Related to issue 2207

Description

The issue 2207 added a warning for "unsaved changes might get lost", however, I found it annoying that the message poped up also at the default value...

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

Additional Information

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/2410 **Author:** [@moritzmock](https://github.com/moritzmock) **Created:** 6/11/2022 **Status:** ✅ Merged **Merged:** 6/14/2022 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `main` ← **Head:** `check_confirmation` --- ### 📝 Commits (4) - [`1aca454`](https://github.com/hoppscotch/hoppscotch/commit/1aca454a3eb92b900c9f3f8656f048d2420daa7b) feat: checks only if not default param - [`7b21848`](https://github.com/hoppscotch/hoppscotch/commit/7b218485a39d833d42c8d0cb785c4b5eacbdea59) fix: moved logic - [`ae15113`](https://github.com/hoppscotch/hoppscotch/commit/ae15113e9d5388249a16935fe2bdef6e4d9b66da) Update packages/hoppscotch-app/components/collections/my/Request.vue - [`9e1b8d7`](https://github.com/hoppscotch/hoppscotch/commit/9e1b8d794609cd49b660b70a68fee47c0ff38213) fix: added commented and fixed typo ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-app/components/collections/my/Request.vue` (+4 -0) </details> ### 📄 Description   Related to issue 2207 ### Description  The issue 2207 added a warning for "unsaved changes might get lost", however, I found it annoying that the message poped up also at the default value...  ### Checks  - [x] My pull request adheres to the code style of this project - [x] My code requires changes to the documentation - [x] I have updated the documentation as required - [x] All the tests have passed ### Additional Information  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>