[PR #3465] [MERGED] fix(common): 🐛 allows URL parsing as obsvered in #1873 #4391

Closed
opened 2026-03-17 01:56:01 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3465
Author: @kpguru20001
Created: 10/21/2023
Status: Merged
Merged: 11/1/2023
Merged by: @AndrewBastin

Base: release/2023.8.3Head: fix/regex-issue-1873


📝 Commits (1)

  • ead1da4 fix(common): 🐛 allows URL parsing as obsvered in #1873

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 packages/hoppscotch-common/src/workers/regex.js (+2 -2)

📄 Description

Closes # 1873 [This only deals with the parsing issue and not the underlying problem the issue pertains to]

Description

minor fix to allow regex parsing of urls like wss://ris-live.ripe.net/v1/ws/?client=hoppscotch.io.

Checks

  • My pull request adheres to the code style of this project
  • [] My code requires changes to the documentation
  • [] I have updated the documentation as required
  • All the tests have passed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3465 **Author:** [@kpguru20001](https://github.com/kpguru20001) **Created:** 10/21/2023 **Status:** ✅ Merged **Merged:** 11/1/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `release/2023.8.3` ← **Head:** `fix/regex-issue-1873` --- ### 📝 Commits (1) - [`ead1da4`](https://github.com/hoppscotch/hoppscotch/commit/ead1da42032cb1c568fe476aa3c5645d18c60c58) fix(common): :bug: allows URL parsing as obsvered in #1873 ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/workers/regex.js` (+2 -2) </details> ### 📄 Description <!-- Thanks for creating this pull request 🤗 Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one. --> <!-- If this pull request closes an issue, please mention the issue number below --> ~~Closes # 1873~~ [This only deals with the parsing issue and not the underlying problem the issue pertains to] ### Description minor fix to allow regex parsing of urls like `wss://ris-live.ripe.net/v1/ws/?client=hoppscotch.io`. ### Checks <!-- Make sure your pull request passes the CI checks and do check the following fields as needed - --> - [x] My pull request adheres to the code style of this project - [] My code requires changes to the documentation - [] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 01:56:01 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4391
No description provided.