[PR #1720] [MERGED] refactor: modals #3465

New issue

Closed

opened 2026-03-17 01:04:32 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:04:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/1720
Author: @s-r-x
Created: 6/14/2021
Status: ✅ Merged
Merged: 6/15/2021
Merged by: @liyasthomas

Base: main ← Head: fix/modals

📝 Commits (4)

1411be3 refactor: * @linusborg/vue-simple-portal dependency. * Emit "close" event inside generic Modal component on backdrop click. * Render Modal in Portal. * Listen for "escape" key input(when it controls visibility of various modals) directly in Modal component. * remove "escape" key listeners from components/collections/index.vue, pages/index.vue and other components that render modals. * "escape" key now closes only the active modal, not all at once(in case when there are multiple modals, for example "save request" and "new folder" on top of it"
471cec4 fix: modal exit animation / move from vue-simple-portal to the custom portal solution
9cbdc77 chore: rm @linusborg/vue-simple-portal dep
63709c0 chore: lint

📊 Changes

9 files changed (+38525 additions, -175 deletions)

View changed files

📝 components/app/Header.vue (+0 -11)
📝 components/collections/graphql/index.vue (+0 -18)
📝 components/collections/index.vue (+0 -17)
📝 components/environments/index.vue (+0 -15)
📝 components/firebase/Email.vue (+0 -11)
📝 components/smart/ConfirmModal.vue (+0 -12)
📝 components/smart/Modal.vue (+64 -2)
📝 package-lock.json (+38461 -80)
📝 pages/index.vue (+0 -9)

📄 Description

Hello ^-^. This pr fixes various modal ux pain points and makes the procedure of adding a new modal more convenient for developers

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/1720 **Author:** [@s-r-x](https://github.com/s-r-x) **Created:** 6/14/2021 **Status:** ✅ Merged **Merged:** 6/15/2021 **Merged by:** [@liyasthomas](https://github.com/liyasthomas) **Base:** `main` ← **Head:** `fix/modals` --- ### 📝 Commits (4) - [`1411be3`](https://github.com/hoppscotch/hoppscotch/commit/1411be373439705376af10b7a7f37732b46526ee) refactor: * @linusborg/vue-simple-portal dependency. * Emit "close" event inside generic Modal component on backdrop click. * Render Modal in Portal. * Listen for "escape" key input(when it controls visibility of various modals) directly in Modal component. * remove "escape" key listeners from components/collections/index.vue, pages/index.vue and other components that render modals. * "escape" key now closes only the active modal, not all at once(in case when there are multiple modals, for example "save request" and "new folder" on top of it" - [`471cec4`](https://github.com/hoppscotch/hoppscotch/commit/471cec4c8a365433dd0a2d182e080161b1f01d16) fix: modal exit animation / move from vue-simple-portal to the custom portal solution - [`9cbdc77`](https://github.com/hoppscotch/hoppscotch/commit/9cbdc7735de3d606da9379e7459a73a8265f245b) chore: rm @linusborg/vue-simple-portal dep - [`63709c0`](https://github.com/hoppscotch/hoppscotch/commit/63709c0f38abcada2d08b34fbfdfddf91e223a2c) chore: lint ### 📊 Changes **9 files changed** (+38525 additions, -175 deletions) <details> <summary>View changed files</summary> 📝 `components/app/Header.vue` (+0 -11) 📝 `components/collections/graphql/index.vue` (+0 -18) 📝 `components/collections/index.vue` (+0 -17) 📝 `components/environments/index.vue` (+0 -15) 📝 `components/firebase/Email.vue` (+0 -11) 📝 `components/smart/ConfirmModal.vue` (+0 -12) 📝 `components/smart/Modal.vue` (+64 -2) 📝 `package-lock.json` (+38461 -80) 📝 `pages/index.vue` (+0 -9) </details> ### 📄 Description Hello ^-^. This pr fixes various modal ux pain points and makes the procedure of adding a new modal more convenient for developers --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>