[PR #3176] [CLOSED] Fixed team invite case sensitive and admin can't delete invites #4270

New issue

Closed

opened 2026-03-17 01:49:12 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:49:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/3176
Author: @RaHehl
Created: 7/7/2023
Status: ❌ Closed

Base: main ← Head: fix-invite-email-casesensitive-and-admin-cannot-delete-invite

📝 Commits (1)

6a31fa4 Fixed a user is not allowed to accept invite because of email comparisation is case sensitive. Also fixed a admin user is not able to delete invitation in teams he don't own.

📊 Changes

3 files changed (+3 additions, -3 deletions)

View changed files

📝 packages/hoppscotch-backend/src/team-invitation/team-invitation.service.ts (+1 -1)
📝 packages/hoppscotch-backend/src/team-invitation/team-invite-team-owner.guard.ts (+1 -1)
📝 packages/hoppscotch-backend/src/team-invitation/team-invitee.guard.ts (+1 -1)

📄 Description

I had the problem that by using MS as an authentication provider, users ended up in the database with email addresses in which the first letter of the first and last name was capitalized, which is basically not a problem. However, this meant that if the team invite was not spelled exactly the same way, it was not possible to accept it.

The second problem was that if I hadn't created the invite or the team, as an admin I couldn't delete the broken invite because it only checked whether I had the necessary role in the team.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/3176 **Author:** [@RaHehl](https://github.com/RaHehl) **Created:** 7/7/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix-invite-email-casesensitive-and-admin-cannot-delete-invite` --- ### 📝 Commits (1) - [`6a31fa4`](https://github.com/hoppscotch/hoppscotch/commit/6a31fa49c3465aee5d27be9bb04a070b966355d9) Fixed a user is not allowed to accept invite because of email comparisation is case sensitive. Also fixed a admin user is not able to delete invitation in teams he don't own. ### 📊 Changes **3 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-backend/src/team-invitation/team-invitation.service.ts` (+1 -1) 📝 `packages/hoppscotch-backend/src/team-invitation/team-invite-team-owner.guard.ts` (+1 -1) 📝 `packages/hoppscotch-backend/src/team-invitation/team-invitee.guard.ts` (+1 -1) </details> ### 📄 Description I had the problem that by using MS as an authentication provider, users ended up in the database with email addresses in which the first letter of the first and last name was capitalized, which is basically not a problem. However, this meant that if the team invite was not spelled exactly the same way, it was not possible to accept it. The second problem was that if I hadn't created the invite or the team, as an admin I couldn't delete the broken invite because it only checked whether I had the necessary role in the team. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>