[PR #1255] [MERGED] Run tests against all codegen instead of individual ones #3176

New issue

Closed

opened 2026-03-17 00:48:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 00:48:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/1255
Author: @yq314
Created: 10/9/2020
Status: ✅ Merged
Merged: 10/9/2020
Merged by: @liyasthomas

Base: master ← Head: refactor-tests-for-all-codegen

📝 Commits (3)

1b065b1 run tests against all codegens instead of individual ones
57dc9d9 table testing
b4d5ff5 fixture is no longer needed

📊 Changes

6 files changed (+957 additions, -190 deletions)

View changed files

➕ helpers/codegen/__tests__/__snapshots__/codegen.spec.js.snap (+863 -0)
➕ helpers/codegen/__tests__/codegen.spec.js (+91 -0)
➖ helpers/codegen/generators/__fixtures__/test-data.js (+0 -16)
➖ helpers/codegen/generators/__tests__/__snapshots__/nodejs-native.spec.js.snap (+0 -98)
➖ helpers/codegen/generators/__tests__/nodejs-native.spec.js (+0 -74)
📝 helpers/codegen/generators/curl.js (+3 -2)

📄 Description

Realized we don't need to write tests for generators separately as they are going to be exactly the same.

Instead, we just need to run the same set of tests against all generators at one go.

By doing this, discovered a bug in the curl generator that auth is not being passed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/1255 **Author:** [@yq314](https://github.com/yq314) **Created:** 10/9/2020 **Status:** ✅ Merged **Merged:** 10/9/2020 **Merged by:** [@liyasthomas](https://github.com/liyasthomas) **Base:** `master` ← **Head:** `refactor-tests-for-all-codegen` --- ### 📝 Commits (3) - [`1b065b1`](https://github.com/hoppscotch/hoppscotch/commit/1b065b13898fe8ad0865739e1b3cae50b076c1a5) run tests against all codegens instead of individual ones - [`57dc9d9`](https://github.com/hoppscotch/hoppscotch/commit/57dc9d99a1a60bc28759a5f2f71e88bbbd10b011) table testing - [`b4d5ff5`](https://github.com/hoppscotch/hoppscotch/commit/b4d5ff5d60bf9871bf2b1d5b8b9c3229662b62de) fixture is no longer needed ### 📊 Changes **6 files changed** (+957 additions, -190 deletions) <details> <summary>View changed files</summary> ➕ `helpers/codegen/__tests__/__snapshots__/codegen.spec.js.snap` (+863 -0) ➕ `helpers/codegen/__tests__/codegen.spec.js` (+91 -0) ➖ `helpers/codegen/generators/__fixtures__/test-data.js` (+0 -16) ➖ `helpers/codegen/generators/__tests__/__snapshots__/nodejs-native.spec.js.snap` (+0 -98) ➖ `helpers/codegen/generators/__tests__/nodejs-native.spec.js` (+0 -74) 📝 `helpers/codegen/generators/curl.js` (+3 -2) </details> ### 📄 Description Realized we don't need to write tests for generators separately as they are going to be exactly the same. Instead, we just need to run the same set of tests against all generators at one go. By doing this, discovered a bug in the curl generator that `auth` is not being passed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>