[PR #2948] [MERGED] fix: reordering bugs and UX fixes #4149

New issue

Closed

opened 2026-03-17 01:42:38 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:42:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/2948
Author: @nivedin
Created: 3/13/2023
Status: ✅ Merged
Merged: 3/14/2023
Merged by: @AndrewBastin

Base: staging ← Head: fix/my-collection-parent-child-move

📝 Commits (8)

66f2b92 fix: disable moving parent to child in my coll
54a32e5 fix: reorder not same parent bug my coll
9a17929 fix: ease reorder flow
646248e fix: collection, req name drag over fix
6ffe19f chore: increase reorder drop area
1d97f94 fix: reorder in incorrect position
525adb9 refactor: introduce store to get reorder item
7d63941 refactor: disable reordering within diff parent

📊 Changes

9 files changed (+390 additions, -183 deletions)

View changed files

📝 packages/hoppscotch-common/src/components.d.ts (+0 -1)
📝 packages/hoppscotch-common/src/components/collections/Collection.vue (+90 -28)
📝 packages/hoppscotch-common/src/components/collections/MyCollections.vue (+4 -0)
📝 packages/hoppscotch-common/src/components/collections/Request.vue (+89 -36)
📝 packages/hoppscotch-common/src/components/collections/TeamCollections.vue (+3 -0)
📝 packages/hoppscotch-common/src/components/collections/index.vue (+134 -97)
📝 packages/hoppscotch-common/src/helpers/teams/TeamCollectionAdapter.ts (+12 -12)
📝 packages/hoppscotch-common/src/newstore/collections.ts (+12 -9)
➕ packages/hoppscotch-common/src/newstore/reordering.ts (+46 -0)

📄 Description

Description

This PR fixes the UI and UX flow fixes for the reordering and moving feature

disable moving a parent-to-child collection
ease reorder flow
increase user feedback while reordering and moving

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/2948 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 3/13/2023 **Status:** ✅ Merged **Merged:** 3/14/2023 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `staging` ← **Head:** `fix/my-collection-parent-child-move` --- ### 📝 Commits (8) - [`66f2b92`](https://github.com/hoppscotch/hoppscotch/commit/66f2b924a06e8afa2ae9958b820f30c3da55afe7) fix: disable moving parent to child in my coll - [`54a32e5`](https://github.com/hoppscotch/hoppscotch/commit/54a32e5be35727944bb6e6ec69390556a997a5fc) fix: reorder not same parent bug my coll - [`9a17929`](https://github.com/hoppscotch/hoppscotch/commit/9a17929b0f09898cd6e8cc1346731d2cb53f741f) fix: ease reorder flow - [`646248e`](https://github.com/hoppscotch/hoppscotch/commit/646248ea2c30029a065ef87a4fa1b45c43e19f99) fix: collection, req name drag over fix - [`6ffe19f`](https://github.com/hoppscotch/hoppscotch/commit/6ffe19fc02006e6d59494c56f74439e23a1b771e) chore: increase reorder drop area - [`1d97f94`](https://github.com/hoppscotch/hoppscotch/commit/1d97f948bbd7c375e60ac9124583a5391bcd1b57) fix: reorder in incorrect position - [`525adb9`](https://github.com/hoppscotch/hoppscotch/commit/525adb97e8ababc9061a7a35926bc849a922766a) refactor: introduce store to get reorder item - [`7d63941`](https://github.com/hoppscotch/hoppscotch/commit/7d639414db0181b25bb7a8331d5d5010b0005597) refactor: disable reordering within diff parent ### 📊 Changes **9 files changed** (+390 additions, -183 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components.d.ts` (+0 -1) 📝 `packages/hoppscotch-common/src/components/collections/Collection.vue` (+90 -28) 📝 `packages/hoppscotch-common/src/components/collections/MyCollections.vue` (+4 -0) 📝 `packages/hoppscotch-common/src/components/collections/Request.vue` (+89 -36) 📝 `packages/hoppscotch-common/src/components/collections/TeamCollections.vue` (+3 -0) 📝 `packages/hoppscotch-common/src/components/collections/index.vue` (+134 -97) 📝 `packages/hoppscotch-common/src/helpers/teams/TeamCollectionAdapter.ts` (+12 -12) 📝 `packages/hoppscotch-common/src/newstore/collections.ts` (+12 -9) ➕ `packages/hoppscotch-common/src/newstore/reordering.ts` (+46 -0) </details> ### 📄 Description ### Description This PR fixes the UI and UX flow fixes for the reordering and moving feature - disable moving a parent-to-child collection - ease reorder flow - increase user feedback while reordering and moving ### Checks - [x] My pull request adheres to the code style of this project - [x] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>