[PR #931] [MERGED] Hide download response button for non-JSON responses #2948

New issue

Closed

opened 2026-03-17 00:36:31 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 00:36:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/931
Author: @AndrewBastin
Created: 6/11/2020
Status: ✅ Merged
Merged: 6/11/2020
Merged by: @liyasthomas

Base: master ← Head: feat/disable-non-json-download

📝 Commits (2)

6ebceca Added support for full content-type headers in isJSONContentType
d111e21 Hide download response button for non-JSON responses

📊 Changes

2 files changed (+24 additions, -6 deletions)

View changed files

📝 functions/utils/contenttypes.js (+15 -5)
📝 pages/index.vue (+9 -1)

📄 Description

This PR intends to introduce the behaviour of the download response button above the response view to be hidden when the response is not a JSON response (detected from content-type).

This is a temporary fix for until the solution for #929 is implemented.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/931 **Author:** [@AndrewBastin](https://github.com/AndrewBastin) **Created:** 6/11/2020 **Status:** ✅ Merged **Merged:** 6/11/2020 **Merged by:** [@liyasthomas](https://github.com/liyasthomas) **Base:** `master` ← **Head:** `feat/disable-non-json-download` --- ### 📝 Commits (2) - [`6ebceca`](https://github.com/hoppscotch/hoppscotch/commit/6ebcecae80d74a5249eca99418500b0016f0240c) Added support for full content-type headers in isJSONContentType - [`d111e21`](https://github.com/hoppscotch/hoppscotch/commit/d111e219c2a52cabee9110d225e0b99fd7c746e0) Hide download response button for non-JSON responses ### 📊 Changes **2 files changed** (+24 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `functions/utils/contenttypes.js` (+15 -5) 📝 `pages/index.vue` (+9 -1) </details> ### 📄 Description This PR intends to introduce the behaviour of the download response button above the response view to be hidden when the response is not a JSON response (detected from content-type). This is a temporary fix for until the solution for #929 is implemented. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>