[PR #2131] [MERGED] refactor: combine add and edit environment modals #3637

New issue

Closed

opened 2026-03-17 01:14:07 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 01:14:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/2131
Author: @kyteinsky
Created: 2/25/2022
Status: ✅ Merged
Merged: 3/7/2022
Merged by: @AndrewBastin

Base: main ← Head: refactor/environ-ease

📝 Commits (3)

df48c50 refactor: combine add and edit environment modals
4404fe8 fix: pass env vars of pre-request script to details modal
7600fb7 fix: type issues

📊 Changes

4 files changed (+56 additions, -108 deletions)

View changed files

➖ packages/hoppscotch-app/components/environments/Add.vue (+0 -78)
📝 packages/hoppscotch-app/components/environments/Details.vue (+31 -5)
📝 packages/hoppscotch-app/components/environments/index.vue (+10 -10)
📝 packages/hoppscotch-app/components/http/TestResult.vue (+15 -15)

📄 Description

Description

Combines add and edit modals for ease of use.

@liyasthomas @AndrewBastin

Please check if the PR does what it needs to.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/2131 **Author:** [@kyteinsky](https://github.com/kyteinsky) **Created:** 2/25/2022 **Status:** ✅ Merged **Merged:** 3/7/2022 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `main` ← **Head:** `refactor/environ-ease` --- ### 📝 Commits (3) - [`df48c50`](https://github.com/hoppscotch/hoppscotch/commit/df48c5086f3a6418ae8a0ccdad76560bc89f59ca) refactor: combine add and edit environment modals - [`4404fe8`](https://github.com/hoppscotch/hoppscotch/commit/4404fe8f4b3637ae583811f0731720db690f7a9e) fix: pass env vars of pre-request script to details modal - [`7600fb7`](https://github.com/hoppscotch/hoppscotch/commit/7600fb79b821de2b9fb30e88657dfbafa2487732) fix: type issues ### 📊 Changes **4 files changed** (+56 additions, -108 deletions) <details> <summary>View changed files</summary> ➖ `packages/hoppscotch-app/components/environments/Add.vue` (+0 -78) 📝 `packages/hoppscotch-app/components/environments/Details.vue` (+31 -5) 📝 `packages/hoppscotch-app/components/environments/index.vue` (+10 -10) 📝 `packages/hoppscotch-app/components/http/TestResult.vue` (+15 -15) </details> ### 📄 Description ### Description  Combines add and edit modals for ease of use. @liyasthomas @AndrewBastin Please check if the PR does what it needs to. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>