starred/hoppscotch

Fork 0

mirror of https://github.com/hoppscotch/hoppscotch.git synced 2026-04-26 09:16:03 +03:00

[GH-ISSUE #74] App is broken with old history in localStorage #32

New issue

Closed

opened 2026-03-16 12:52:31 +03:00 by kerem · 5 comments

kerem commented

2026-03-16 12:52:31 +03:00

Owner

Originally created by @nickpalenchar on GitHub (Aug 28, 2019).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/74

Describe the bug
Starting after 271bd06 (or perhaps around then), old localStorage from a user agent causes the app to break when navigating to the app.

To Reproduce
Steps to reproduce the behavior:

Open the browser and open devTools
Go to the tab for storage, click on localstorage
Edit the history section to be [{"time":"2:57:54 PM","method":"POST","url":"https://reqres.in","path":"/api/users"},{"time":"2:56:30 PM","method":"GET","url":"https://reqres.in","path":"/api/users"},{"time":"10:33:28 AM","method":"GET","url":"https://reqres.in","path":"/api/users"}]
Go to the postwoman page to get the app to break

Expected behavior
The app should fully load, any old history that can't be deciphered should be displayed with as much information as possible.

Desktop (please complete the following information):

OS: Mac OS Sierra
Browser: Firefox
Version 68.0 (64-bit)

Originally created by @nickpalenchar on GitHub (Aug 28, 2019). Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/74 **Describe the bug** Starting after [`271bd06`](https://github.com/liyasthomas/postwoman/commit/271bd061765f1d2d065aac8cf2b82a36d8e68117) (or perhaps around then), old localStorage from a user agent causes the app to break when navigating to the app. **To Reproduce** Steps to reproduce the behavior: 1. Open the browser and open devTools 2. Go to the tab for storage, click on localstorage 3. Edit the history section to be `[{"time":"2:57:54 PM","method":"POST","url":"https://reqres.in","path":"/api/users"},{"time":"2:56:30 PM","method":"GET","url":"https://reqres.in","path":"/api/users"},{"time":"10:33:28 AM","method":"GET","url":"https://reqres.in","path":"/api/users"}]` 4. Go to the postwoman page to get the app to break **Expected behavior** The app should fully load, any old history that can't be deciphered should be displayed with as much information as possible. **Desktop (please complete the following information):** - OS: Mac OS Sierra - Browser: Firefox - Version 68.0 (64-bit)

kerem

2026-03-16 12:52:31 +03:00

closed this issue
added the
bug
label

kerem commented

2026-03-16 12:52:47 +03:00

Author

Owner

@nickpalenchar commented on GitHub (Aug 28, 2019):

FYI I have a working solution that I am preparing 😎

@nickpalenchar commented on GitHub (Aug 28, 2019): FYI I have a working solution that I am preparing 😎

kerem commented

2026-03-16 12:52:52 +03:00

Author

Owner

@liyasthomas commented on GitHub (Aug 28, 2019):

I suspect this is the reason for few other issues that have reported and solved on flushing cache and local storage 🤔

Btw, these kinda people (@nickpalenchar) are 💎

@liyasthomas commented on GitHub (Aug 28, 2019): I suspect this is the reason for few other issues that have reported and solved on flushing cache and local storage 🤔 Btw, these kinda people (@nickpalenchar) are 💎

kerem commented

2026-03-16 12:52:57 +03:00

Author

Owner

@nickpalenchar commented on GitHub (Aug 28, 2019):

Agreed it's most likely the cause of other people's issues re: clearing cache/storage. What's nice is this bug points out a clear area to tackle when thinking about tests re #65.

It would be awesome to have some sort of regression tests, but quick(er) win would probably be to start in an e2e testing--something that would verify there are only expected properties (adding new ones would be fine, but the contributor would then have to acknowledge the change by updating the tests.). But that's a discussion for another feature

@nickpalenchar commented on GitHub (Aug 28, 2019): Agreed it's most likely the cause of other people's issues re: clearing cache/storage. What's nice is this bug points out a clear area to tackle when thinking about tests re #65. It would be awesome to have some sort of regression tests, but quick(er) win would probably be to start in an e2e testing--something that would verify there are only expected properties (adding new ones would be fine, but the contributor would then have to acknowledge the change by updating the tests.). But that's a discussion for another feature

kerem commented

2026-03-16 12:53:02 +03:00

Author

Owner

@liyasthomas commented on GitHub (Sep 6, 2019):

@all-contributors please add @nickpalenchar for code

@liyasthomas commented on GitHub (Sep 6, 2019): @all-contributors please add @nickpalenchar for code

kerem commented

2026-03-16 12:53:07 +03:00

Author

Owner

@allcontributors[bot] commented on GitHub (Sep 6, 2019):

@liyasthomas

We had trouble processing your request. Please try again later.

@allcontributors[bot] commented on GitHub (Sep 6, 2019): @liyasthomas We had trouble processing your request. Please try again later.