starred/hoppscotch

Fork 0

mirror of https://github.com/hoppscotch/hoppscotch.git synced 2026-04-25 16:55:59 +03:00

[GH-ISSUE #164] Add Docker #65

New issue

Closed

opened 2026-03-16 13:07:43 +03:00 by kerem · 14 comments

kerem commented

2026-03-16 13:07:43 +03:00

Owner

Originally created by @jgroom33 on GitHub (Sep 25, 2019).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/164

it would be nice to have no install dependencies except docker.

expected behavior: docker run -it -p 3000:3000 liyasthomas/postwoman:latest

Originally created by @jgroom33 on GitHub (Sep 25, 2019). Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/164 it would be nice to have no install dependencies except docker. expected behavior: `docker run -it -p 3000:3000 liyasthomas/postwoman:latest`

kerem

2026-03-16 13:07:43 +03:00

closed this issue
added the
feature
label

kerem commented

2026-03-16 13:08:00 +03:00

Author

Owner

@jgroom33 commented on GitHub (Sep 25, 2019):

@liyasthomas
“Set up Automated Builds using GitHub and Docker Hub” by oleksii_y https://link.medium.com/AmD5s8x6f0

@jgroom33 commented on GitHub (Sep 25, 2019): @liyasthomas “Set up Automated Builds using GitHub and Docker Hub” by oleksii_y https://link.medium.com/AmD5s8x6f0

kerem commented

2026-03-16 13:08:05 +03:00

Author

Owner

@liyasthomas commented on GitHub (Sep 25, 2019):

We're already making use of Travis CI for deployments. And I'm not experienced with docker. Would you care to explain docker CD advantages over other CIs?

@liyasthomas commented on GitHub (Sep 25, 2019): We're already making use of Travis CI for deployments. And I'm not experienced with docker. Would you care to explain docker CD advantages over other CIs?

kerem commented

2026-03-16 13:08:10 +03:00

Author

Owner

@jgroom33 commented on GitHub (Sep 25, 2019):

the requirement is:
Publish an image to docker hub liyasthomas/postwoman

This account needs to exist so the image can be published there.

Then the image needs to be pushed there.

It's probably possible to do this with Travis, but it would require that to be setup in Travis. (Ie add a token for docker hub in Travis)

If docker hub is used, the process is easier. Just link your GitHub account from docker hub and it will watch for new releases. When a new release is published, it builds the image using the docker file and publishes it.

@jgroom33 commented on GitHub (Sep 25, 2019): the requirement is: Publish an image to docker hub liyasthomas/postwoman This account needs to exist so the image can be published there. Then the image needs to be pushed there. It's probably possible to do this with Travis, but it would require that to be setup in Travis. (Ie add a token for docker hub in Travis) If docker hub is used, the process is easier. Just link your GitHub account from docker hub and it will watch for new releases. When a new release is published, it builds the image using the docker file and publishes it.

kerem commented

2026-03-16 13:08:15 +03:00

Author

Owner

@liyasthomas commented on GitHub (Sep 25, 2019):

Cool! Let me do a background check on it and will let you know.

@liyasthomas commented on GitHub (Sep 25, 2019): Cool! Let me do a background check on it and will let you know.

kerem commented

2026-03-16 13:08:20 +03:00

Author

Owner

@liyasthomas commented on GitHub (Sep 25, 2019):

Closed by accident

@liyasthomas commented on GitHub (Sep 25, 2019): Closed by accident

kerem commented

2026-03-16 13:08:25 +03:00

Author

Owner

@liyasthomas commented on GitHub (Sep 26, 2019):

@jgroom33
https://hub.docker.com/r/liyasthomas/postwoman
docker pull liyasthomas/postwoman

@liyasthomas commented on GitHub (Sep 26, 2019): @jgroom33 https://hub.docker.com/r/liyasthomas/postwoman `docker pull liyasthomas/postwoman`

kerem commented

2026-03-16 13:08:30 +03:00

Author

Owner

@jgroom33 commented on GitHub (Sep 26, 2019):

Works great. Now just need to update the readme with:
docker run -p 3000:3000 liyasthomas/postwoman:latest

@jgroom33 commented on GitHub (Sep 26, 2019): Works great. Now just need to update the readme with: `docker run -p 3000:3000 liyasthomas/postwoman:latest`

kerem commented

2026-03-16 13:08:35 +03:00

Author

Owner

@liyasthomas commented on GitHub (Sep 26, 2019):

Will do

@liyasthomas commented on GitHub (Sep 26, 2019): Will do

kerem commented

2026-03-16 13:08:40 +03:00

Author

Owner

@liyasthomas commented on GitHub (Sep 27, 2019):

@jgroom33 can you tell me why docker taking ~12 mins to build? Any optimizations you wanna suggest to dockerfile?

@liyasthomas commented on GitHub (Sep 27, 2019): @jgroom33 can you tell me why docker taking ~12 mins to build? Any optimizations you wanna suggest to `dockerfile`?

kerem commented

2026-03-16 13:08:46 +03:00

Author

Owner

@jgroom33 commented on GitHub (Sep 27, 2019):

Where are you seeing the 12 minutes?
One of the things that would be good is to use an alpine image. They are much smaller (50M compared to 300M)
But that would only impact time if the root image is being downloaded each build.
I tried to use an alpine image originally, but the build failed.

@jgroom33 commented on GitHub (Sep 27, 2019): Where are you seeing the 12 minutes? One of the things that would be good is to use an alpine image. They are much smaller (50M compared to 300M) But that would only impact time if the root image is being downloaded each build. I tried to use an alpine image originally, but the build failed.

kerem commented

2026-03-16 13:08:51 +03:00

Author

Owner

@liyasthomas commented on GitHub (Sep 27, 2019):

Build duration was 12 mins.
Let me see if I could build with alpine rather than buster.

@liyasthomas commented on GitHub (Sep 27, 2019): Build duration was 12 mins. Let me see if I could build with alpine rather than buster.

kerem commented

2026-03-16 13:08:56 +03:00

Author

Owner

@jgroom33 commented on GitHub (Sep 27, 2019):

https://hub.docker.com/_/node/?tab=tags&page=1&name=alpine

@jgroom33 commented on GitHub (Sep 27, 2019): https://hub.docker.com/_/node/?tab=tags&page=1&name=alpine

kerem commented

2026-03-16 13:09:01 +03:00

Author

Owner

@jls-tschanzc commented on GitHub (Dec 2, 2019):

Another improvement might be to use tini and switching from "npm run start" to directly executing the nuxt command. Just add "tini" to the apk add command and then switch the CMD line with:

ENTRYPOINT ["/sbin/tini", "--"]
CMD ["nuxt", "start"]

Another nice to have feature might be a healthcheck, something like this:

HEALTHCHECK --interval=5m --timeout=3s CMD curl --fail http://localhost:3000/health || exit 1

I am not entirely sure how nuxt works and what dependencies it needs for runtime but maybe it could further slim down the resulting image by using a multi stage build so you would prepare everything for the npm run build in the first stage and run the build and then in the second stage you would only copy over the resulting build artefacts and set ENV NODE_ENV production as well as run only npm install --only=prod (IF all the dependencies are even required for nuxt to run).

@jls-tschanzc commented on GitHub (Dec 2, 2019): Another improvement might be to use [tini](https://github.com/krallin/tini) and switching from "npm run start" to directly executing the nuxt command. Just add "tini" to the `apk add` command and then switch the CMD line with: ``` ENTRYPOINT ["/sbin/tini", "--"] CMD ["nuxt", "start"] ``` Another nice to have feature might be a [healthcheck](https://docs.docker.com/engine/reference/builder/#healthcheck), something like this: ``` HEALTHCHECK --interval=5m --timeout=3s CMD curl --fail http://localhost:3000/health || exit 1 ``` I am not entirely sure how nuxt works and what dependencies it needs for runtime but maybe it could further slim down the resulting image by using a [multi stage build](https://docs.docker.com/develop/develop-images/multistage-build/) so you would prepare everything for the `npm run build` in the first stage and run the build and then in the second stage you would only copy over the resulting build artefacts and set `ENV NODE_ENV production` as well as run only `npm install --only=prod` (IF all the `dependencies` are even required for nuxt to run).

kerem commented

2026-03-16 13:09:06 +03:00

Author

Owner

@pidario commented on GitHub (Jan 13, 2020):

Sorry to comment under a closed issue, but in response to the previous comment I tried this Dockerfile:

FROM node:12.10.0-alpine as builder

WORKDIR /app

# Add git as the prebuild target requires it to parse version information
RUN apk add --update --no-cache \
  git \
  tini \
  ca-certificates

COPY package*.json ./

RUN npm install

COPY . .

RUN npm run build
######################################################################################
FROM node:12.10.0-alpine as runner

LABEL maintainer="Liyas Thomas (liyascthomas@gmail.com)"

COPY --from=builder /sbin/tini /sbin/tini
COPY --from=builder /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certificates.crt

WORKDIR /app

COPY --from=builder /app .

EXPOSE 3000

ENTRYPOINT ["/sbin/tini", "--"]
CMD ["node_modules/.bin/nuxt", "start"]

I added tini as suggested and I also took the liberty to add ca-certificates.

I usually build this Dockerfile by using two different commands in sequence:
docker build --target builder -t builder-postwoman:latest .
This image is used for caching purposes only and is not pushed to docker hub: note the tag is just builder-postwoman;
and then
docker build --target runner -t liyasthomas/postwoman:latest .
This one instead has the usual tag you currently use and will be pushed to DH.

The image got shrunk down to 303MB, which is not bad for a nodejs application this large but probably you could still improve it by installing production dependencies only (for example you don't need test suite in production) as suggested by @jls-tschanzc

@pidario commented on GitHub (Jan 13, 2020): Sorry to comment under a closed issue, but in response to the previous comment I tried this Dockerfile: ``` FROM node:12.10.0-alpine as builder WORKDIR /app # Add git as the prebuild target requires it to parse version information RUN apk add --update --no-cache \ git \ tini \ ca-certificates COPY package*.json ./ RUN npm install COPY . . RUN npm run build ###################################################################################### FROM node:12.10.0-alpine as runner LABEL maintainer="Liyas Thomas (liyascthomas@gmail.com)" COPY --from=builder /sbin/tini /sbin/tini COPY --from=builder /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certificates.crt WORKDIR /app COPY --from=builder /app . EXPOSE 3000 ENTRYPOINT ["/sbin/tini", "--"] CMD ["node_modules/.bin/nuxt", "start"] ``` I added tini as suggested and I also took the liberty to add ca-certificates. I usually build this Dockerfile by using two different commands in sequence: `docker build --target builder -t builder-postwoman:latest .` This image is used for caching purposes only and is not pushed to docker hub: note the tag is just builder-postwoman; and then `docker build --target runner -t liyasthomas/postwoman:latest .` This one instead has the usual tag you currently use and will be pushed to DH. The image got shrunk down to 303MB, which is not bad for a nodejs application this large but probably you could still improve it by installing production dependencies only (for example you don't need test suite in production) as suggested by @jls-tschanzc

kerem referenced this issue

2026-03-17 00:08:51 +03:00

[PR #151] [CLOSED] Auto deploy testing branches, test and report #2444

kerem referenced this issue

2026-03-17 00:08:51 +03:00

[PR #148] [CLOSED] Auto deploy pull requests, test and report #2445

kerem referenced this issue

2026-03-17 00:09:57 +03:00

[PR #181] [MERGED] Add basic e2e tests #2462