[PR #195] [CLOSED] feat: semistandard linting #2473

Closed
opened 2026-03-17 00:10:29 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/195
Author: @mdt2
Created: 10/16/2019
Status: Closed

Base: masterHead: feat--semistandard-linting


📝 Commits (3)

  • 5ff7d49 feat: add semistandard linter
  • f341c7c fix: run semistandard --fix to fix some linting errors
  • 6c9584f fix: semistandard to ignore tests

📊 Changes

22 files changed (+1282 additions, -392 deletions)

View changed files

📝 assets/js/curlparser.js (+204 -206)
📝 assets/js/pwa.js (+5 -7)
📝 build.js (+17 -18)
📝 directives/textareaAutoHeight.js (+6 -6)
📝 middleware/parsedefaulturl.js (+3 -3)
📝 nuxt.config.js (+26 -26)
📝 package-lock.json (+933 -44)
📝 package.json (+8 -1)
📝 plugins/vuex-persist.js (+3 -3)
📝 store/index.js (+1 -1)
📝 store/postwoman.js (+25 -26)
📝 tests/e2e/integration/app.starter.spec.js (+3 -3)
📝 tests/e2e/integration/feature.url-queries.spec.js (+43 -43)
tests/e2e/screenshots/app.starter.spec.js/Visit home -- Have a page title with Postwoman (failed).png (+0 -0)
tests/e2e/screenshots/feature.url-queries.spec.js/Methods -- Change the default method GET to DELETE with url query (failed).png (+0 -0)
tests/e2e/screenshots/feature.url-queries.spec.js/Methods -- Change the default method GET to HEAD with url query (failed).png (+0 -0)
tests/e2e/screenshots/feature.url-queries.spec.js/Methods -- Change the default method GET to OPTIONS with url query (failed).png (+0 -0)
tests/e2e/screenshots/feature.url-queries.spec.js/Methods -- Change the default method GET to POST with url query (failed) (1).png (+0 -0)
tests/e2e/screenshots/feature.url-queries.spec.js/Methods -- Change the default method GET to POST with url query (failed).png (+0 -0)
tests/e2e/screenshots/feature.url-queries.spec.js/Methods -- Change the default method GET to PUT with url query (failed).png (+0 -0)

...and 2 more files

📄 Description

Work done to address issue #98

Description of work

  • Add semistandard package for linting
  • Use semistandard's semistandard --fix feature to fix some of the existing linting errors

To test

Pull down the branch and run npm run lint to see semistandard in action


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/195 **Author:** [@mdt2](https://github.com/mdt2) **Created:** 10/16/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feat--semistandard-linting` --- ### 📝 Commits (3) - [`5ff7d49`](https://github.com/hoppscotch/hoppscotch/commit/5ff7d49b08dbe94a2c7ba79d026dada6866c5d03) feat: add semistandard linter - [`f341c7c`](https://github.com/hoppscotch/hoppscotch/commit/f341c7c477a67a9478d088d8cc4ff5b519ee4bb7) fix: run semistandard --fix to fix some linting errors - [`6c9584f`](https://github.com/hoppscotch/hoppscotch/commit/6c9584fba2ad09772a034041c73bcc6bb159de0a) fix: semistandard to ignore tests ### 📊 Changes **22 files changed** (+1282 additions, -392 deletions) <details> <summary>View changed files</summary> 📝 `assets/js/curlparser.js` (+204 -206) 📝 `assets/js/pwa.js` (+5 -7) 📝 `build.js` (+17 -18) 📝 `directives/textareaAutoHeight.js` (+6 -6) 📝 `middleware/parsedefaulturl.js` (+3 -3) 📝 `nuxt.config.js` (+26 -26) 📝 `package-lock.json` (+933 -44) 📝 `package.json` (+8 -1) 📝 `plugins/vuex-persist.js` (+3 -3) 📝 `store/index.js` (+1 -1) 📝 `store/postwoman.js` (+25 -26) 📝 `tests/e2e/integration/app.starter.spec.js` (+3 -3) 📝 `tests/e2e/integration/feature.url-queries.spec.js` (+43 -43) ➕ `tests/e2e/screenshots/app.starter.spec.js/Visit home -- Have a page title with Postwoman (failed).png` (+0 -0) ➕ `tests/e2e/screenshots/feature.url-queries.spec.js/Methods -- Change the default method GET to DELETE with url query (failed).png` (+0 -0) ➕ `tests/e2e/screenshots/feature.url-queries.spec.js/Methods -- Change the default method GET to HEAD with url query (failed).png` (+0 -0) ➕ `tests/e2e/screenshots/feature.url-queries.spec.js/Methods -- Change the default method GET to OPTIONS with url query (failed).png` (+0 -0) ➕ `tests/e2e/screenshots/feature.url-queries.spec.js/Methods -- Change the default method GET to POST with url query (failed) (1).png` (+0 -0) ➕ `tests/e2e/screenshots/feature.url-queries.spec.js/Methods -- Change the default method GET to POST with url query (failed).png` (+0 -0) ➕ `tests/e2e/screenshots/feature.url-queries.spec.js/Methods -- Change the default method GET to PUT with url query (failed).png` (+0 -0) _...and 2 more files_ </details> ### 📄 Description Work done to address issue #98 ## Description of work * Add semistandard package for linting * Use semistandard's `semistandard --fix` feature to fix some of the existing linting errors ## To test Pull down the branch and run `npm run lint` to see semistandard in action --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 00:10:29 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#2473
No description provided.