starred/hoppscotch

Fork 0

mirror of https://github.com/hoppscotch/hoppscotch.git synced 2026-04-26 09:16:03 +03:00

[GH-ISSUE #497] GraphQL String variables are null #195

New issue

Closed

opened 2026-03-16 13:58:56 +03:00 by kerem · 5 comments

kerem commented

2026-03-16 13:58:56 +03:00

Owner

Originally created by @bednam on GitHub (Jan 17, 2020).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/497

Originally assigned to: @pushrbx on GitHub.

Describe the bug
String variables provided for GraphQL query have null values.
Besides unquoted input I also tried to wrap String variable value with double and single quotes but result was the same.

To Reproduce
Steps to reproduce the behavior:

Go to /graphql
Provide GraphQL query
Provide variables (including String type variable)
Click "Run Query"
See null variables values in request preview in console

Screenshots

Desktop

OS: macOS
Browser: chrome
Version 79.0.3945.88 (Official Build) (64-bit)

Additional context
Query performed with proxy disabled in settings

Originally created by @bednam on GitHub (Jan 17, 2020). Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/497 Originally assigned to: @pushrbx on GitHub. **Describe the bug** String variables provided for GraphQL query have null values. Besides unquoted input I also tried to wrap String variable value with double and single quotes but result was the same. **To Reproduce** Steps to reproduce the behavior: 1. Go to /graphql 2. Provide GraphQL query 3. Provide variables (including String type variable) 4. Click "Run Query" 5. See null variables values in request preview in console **Screenshots** ![Screen Shot 2020-01-17 at 11 10 41](https://user-images.githubusercontent.com/23276452/72603819-09870d00-391a-11ea-840e-9dcefec9ecd5.png) ![Screen Shot 2020-01-17 at 11 11 22](https://user-images.githubusercontent.com/23276452/72603871-27547200-391a-11ea-8985-c9166fb7542e.png) **Desktop** - OS: macOS - Browser: chrome - Version 79.0.3945.88 (Official Build) (64-bit) **Additional context** Query performed with proxy disabled in settings

kerem

2026-03-16 13:58:56 +03:00

closed this issue
added the
bug
label

kerem commented

2026-03-16 13:59:12 +03:00

Author

Owner

@liyasthomas commented on GitHub (Jan 17, 2020):

@AndrewBastin @pushrbx

@liyasthomas commented on GitHub (Jan 17, 2020): @AndrewBastin @pushrbx

kerem commented

2026-03-16 13:59:17 +03:00

Author

Owner

@pushrbx commented on GitHub (Jan 17, 2020):

Assign this to me @liyasthomas please, I will do it.

@pushrbx commented on GitHub (Jan 17, 2020): Assign this to me @liyasthomas please, I will do it.

kerem commented

2026-03-16 13:59:22 +03:00

Author

Owner

@liyasthomas commented on GitHub (Jan 17, 2020):

Fine. 🚀

@liyasthomas commented on GitHub (Jan 17, 2020): Fine. 🚀

kerem commented

2026-03-16 13:59:27 +03:00

Author

Owner

@AndrewBastin commented on GitHub (Jan 17, 2020):

Actually, me being busy with cross platform biz, I couldn't catch up on GraphQL updates.

Not gonna sugar coat this, the current implementation for variables sucks. I honestly can't believe I let it go through.

Variables in GraphQL may not be just some simple values, but can also be complex nested objects (facilitated through stuff like Input types)

The best approach to handling variables is either by providing a JSON editor which is parsed into a JS object when the query is ran and then injecting the objects, or by making the current variable editor type sensitive and allowing stuff like nesting.

@AndrewBastin commented on GitHub (Jan 17, 2020): Actually, me being busy with cross platform biz, I couldn't catch up on GraphQL updates. Not gonna sugar coat this, the current implementation for variables sucks. I honestly can't believe I let it go through. Variables in GraphQL may not be just some simple values, but can also be complex nested objects (facilitated through stuff like [Input](https://graphql.org/graphql-js/mutations-and-input-types/) types) The best approach to handling variables is either by providing a JSON editor which is parsed into a JS object when the query is ran and then injecting the objects, or by making the current variable editor type sensitive and allowing stuff like nesting.

kerem commented

2026-03-16 13:59:32 +03:00

Author

Owner

@pushrbx commented on GitHub (Jan 17, 2020):

@AndrewBastin Initially when I added this feature I thought I'd add apollo-client as dependency, because it gives you proper errors for invalid variables, and it has type checking. However it seemed too much effort because a major refactor would be required. God bless laziness.

@pushrbx commented on GitHub (Jan 17, 2020): @AndrewBastin Initially when I added this feature I thought I'd add apollo-client as dependency, because it gives you proper errors for invalid variables, and it has type checking. However it seemed too much effort because a major refactor would be required. God bless laziness.

kerem referenced this issue

2026-03-17 00:10:29 +03:00

[PR #195] [CLOSED] feat: semistandard linting #2473