[PR #125] [MERGED] update with PR for issue/bug #100 #2426

Closed
opened 2026-03-17 00:08:02 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/125
Author: @NileshSP
Created: 8/31/2019
Status: Merged
Merged: 9/1/2019
Merged by: @liyasthomas

Base: masterHead: defaultmenuoptionhighlight


📝 Commits (1)

📊 Changes

4 files changed (+12 additions, -6 deletions)

View changed files

📝 README.md (+1 -0)
📝 middleware/README.md (+4 -5)
middleware/parsedefaulturl.js (+5 -0)
📝 pages/index.vue (+2 -1)

📄 Description

Issue - ideally the default url expected is '/' to highlight the 'Http' menu option but in PWA's case the url passed is '/?standalone=true' to indicate and load it as an app where 'standalone=true' is automatically appended by the rendering browser engine

Solution - newly added middleware 'parsedefaulturl.js' would intercept the request before loading the default page and redirect appropriately as desired


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/125 **Author:** [@NileshSP](https://github.com/NileshSP) **Created:** 8/31/2019 **Status:** ✅ Merged **Merged:** 9/1/2019 **Merged by:** [@liyasthomas](https://github.com/liyasthomas) **Base:** `master` ← **Head:** `defaultmenuoptionhighlight` --- ### 📝 Commits (1) - [`3d1b4f0`](https://github.com/hoppscotch/hoppscotch/commit/3d1b4f0ee261a83f912a028e6820e63c90d89d48) update for issue/bug #100 ### 📊 Changes **4 files changed** (+12 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -0) 📝 `middleware/README.md` (+4 -5) ➕ `middleware/parsedefaulturl.js` (+5 -0) 📝 `pages/index.vue` (+2 -1) </details> ### 📄 Description Issue - ideally the default url expected is '/' to highlight the 'Http' menu option but in PWA's case the url passed is '/?standalone=true' to indicate and load it as an app where 'standalone=true' is automatically appended by the rendering browser engine Solution - newly added middleware 'parsedefaulturl.js' would intercept the request before loading the default page and redirect appropriately as desired --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 00:08:02 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#2426
No description provided.