[GH-ISSUE #339] Separate layers in dockerfile to improve image build #125

New issue

Closed

opened 2026-03-16 13:35:01 +03:00 by kerem · 3 comments

kerem commented

2026-03-16 13:35:01 +03:00

Owner

Originally created by @vitorcx on GitHub (Nov 26, 2019).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/339

Originally assigned to: @vitorcx on GitHub.

Is your feature request related to a problem? Please describe.
The problem is related to the efficiency in the nodejs image building process when we choose to develop/contribute using docker-compose.
I realized that in the current dockerfile there is only one layer responsible for copying all code from the current directory into the container. This results in the need to rebuild the image from this layer whenever any part of the code is changed, which can lead to unnecessary waiting for the npm install process in cases where dependencies have not changed.

Describe the solution you'd like
One possible way to solve this is to separate the layers where the source code and package.json / package-lock.json are copied into the container. Also, copy the remaining source code only after the npm install process. Thus the dependencies will only be reinstalled when new dependencies are changed / added.

Describe alternatives you've considered
Another possibility of improvement is the addition of a docker-compose volume containing the source code, this would allow behavior similar to a hot reloading.

Additional context
Of course, all these suggestions made here are subject to discussion, because I may not be fully aware of the reasons why they are not currently implemented, even though they seems to be simple.

Originally created by @vitorcx on GitHub (Nov 26, 2019). Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/339 Originally assigned to: @vitorcx on GitHub. **Is your feature request related to a problem? Please describe.** The problem is related to the efficiency in the nodejs image building process when we choose to develop/contribute using docker-compose. I realized that in the current dockerfile there is only one layer responsible for copying all code from the current directory into the container. This results in the need to rebuild the image from this layer whenever any part of the code is changed, which can lead to unnecessary waiting for the `npm install` process in cases where dependencies have not changed. **Describe the solution you'd like** One possible way to solve this is to separate the layers where the source code and package.json / package-lock.json are copied into the container. Also, copy the remaining source code only after the `npm install` process. Thus the dependencies will only be reinstalled when new dependencies are changed / added. **Describe alternatives you've considered** Another possibility of improvement is the addition of a docker-compose volume containing the source code, this would allow behavior similar to a hot reloading. **Additional context** Of course, all these suggestions made here are subject to discussion, because I may not be fully aware of the reasons why they are not currently implemented, even though they seems to be simple.

kerem

2026-03-16 13:35:01 +03:00

closed this issue
added the
help wanted

feature
labels

kerem commented

2026-03-16 13:35:17 +03:00

Author

Owner

@liyasthomas commented on GitHub (Nov 26, 2019):

why they are not currently implemented, even though they seems to be simple.

Because I'm a Docker noob. I'm new to Docker and all it's functionalities. It would be great if you could shoot up a PR! I'm still learning Docker, I'll review and merge to master 👍

@liyasthomas commented on GitHub (Nov 26, 2019): > why they are not currently implemented, even though they seems to be simple. Because I'm a Docker noob. I'm new to Docker and all it's functionalities. It would be great if you could shoot up a PR! I'm still learning Docker, I'll review and merge to master 👍

kerem commented

2026-03-16 13:35:22 +03:00

Author

Owner

@vitorcx commented on GitHub (Nov 26, 2019):

why they are not currently implemented, even though they seems to be simple.

Because I'm a Docker noob. I'm new to Docker and all it's functionalities. It would be great if you could shoot up a PR! I'm still learning Docker, I'll review and merge to master

Thanks for replying, i will do it then! It will be a pleasure to help.

@vitorcx commented on GitHub (Nov 26, 2019): > > why they are not currently implemented, even though they seems to be simple. > > Because I'm a Docker noob. I'm new to Docker and all it's functionalities. It would be great if you could shoot up a PR! I'm still learning Docker, I'll review and merge to master Thanks for replying, i will do it then! It will be a pleasure to help.

kerem commented

2026-03-16 13:35:27 +03:00

Author

Owner

@liyasthomas commented on GitHub (Nov 26, 2019):

#340 solves this hence closing

@liyasthomas commented on GitHub (Nov 26, 2019): #340 solves this hence closing

kerem referenced this issue

2026-03-17 00:08:02 +03:00

[PR #125] [MERGED] update with PR for issue/bug #100 #2426