mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[GH-ISSUE #33] Code highlight on response body #14
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#14
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @liyasthomas on GitHub (Aug 23, 2019).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/33
Originally assigned to: @AndrewBastin, @liyasthomas on GitHub.
Is your feature request related to a problem? Please describe.
Response body is displayed in plain textarea.
Describe the solution you'd like
Need code highlighting feature.
Describe alternatives you've considered
https://highlightjs.org
Additional context
Add code highlighting to not only the response body but also to parameter lists, POST request body etc.
@liyasthomas commented on GitHub (Aug 23, 2019):
@AndrewBastin can you take a look at this feature request and possibly make a PR?
@AndrewBastin commented on GitHub (Aug 23, 2019):
Well, I am kinda working on an implementation for this in Prism....
It is a bit hacky, but I am working on one....
If issue #31 is resolved, we can use vue-highlight to do the highlighting hopefully in a less hacky way.
PR coming hopefully tomorrow...
Meanwhile, @liyasthomas you can assign the issue to me
@AndrewBastin commented on GitHub (Aug 24, 2019):
Well, I have kinda almost finished implementing it, just some few small stuff with like CSS issues are left there to fix, but #44 will require a full rewrite of my current implementation so I am not submitting a PR....
But anyways I have pushed the change in my fork for peeps willing to have a peek and are willing to contribute to....
I am just gonna stop working on this right now and move to other stuff...
@AndrewBastin commented on GitHub (Aug 28, 2019):
Sorry for the delays in finishing this, I was kinda busy with travels and stuff... I have submitted a PR #78 resolving the issue with Prism. Please look into it.
@liyasthomas commented on GitHub (Sep 6, 2019):
@AndrewBastin any updates on the issue? I'm hoping to include this feature in the next version release ✨
@JacobAnavisca commented on GitHub (Sep 10, 2019):
Hey guys I just created a PR that uses highlight js, hope that's cool. Probably needs some updates to the CSS I added https://github.com/liyasthomas/postwoman/pull/142
@liyasthomas commented on GitHub (Sep 12, 2019):
#142 solves this issue