mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[GH-ISSUE #206] Display sendRequest runtime errors in the console #78
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#78
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @nickpalenchar on GitHub (Oct 23, 2019).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/206
Originally assigned to: @nickpalenchar on GitHub.
Currently only a specific type of error caught in sendRequest is displayed. All others are swallowed, but the message displayed to the users instructs to check the console for errors. Let's show those errors appropriately so that the resolve makes sense.
@liyasthomas commented on GitHub (Oct 23, 2019):
Thats better! Perhaps show a toast? Than console.log().
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status
@nickpalenchar commented on GitHub (Oct 23, 2019):
Toast would be good. Looking at a why-not-have both approach. Toast would display the error message but having the full error in the console is also good to easily refer to, as well as getting more verbose details like the error stack (this is being implemented as a console.error rather than console log)
@liyasthomas commented on GitHub (Oct 23, 2019):
Yeah! That's correct. Just saw the branch. Make the PR. Will merge right away!