[GH-ISSUE #2250] `DnssecDnsHandle.minimum_{algorithm,key_len}` fields appear to be unused? #937

New issue

Open

opened 2026-03-16 01:01:30 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 01:01:30 +03:00

Owner

Originally created by @japaric on GitHub (Jun 20, 2024).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2250

what the title says. I noticed that DnssecDnsHandle does not have accessor methods to read out these fields outside the module where the struct is defined. the fields also don't get used anywhere in the module except in clone_with_context which just copies them over. the fields cannot be set by an user either as they are always initialized with some default values.

I expected that minimum_{algorithm,key_len} were going be used to check that the keys in TrustAnchor meet those minimums and the TrustAnchor would be rejected if none of its keys met the criteria but that does not seem to be the case

should the fields be removed or are they planned to be used later on?

Originally created by @japaric on GitHub (Jun 20, 2024). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2250 what the title says. I noticed that `DnssecDnsHandle` does not have accessor methods to read out these fields outside the module where the struct is defined. the fields also don't get used anywhere in the module except in `clone_with_context` which just copies them over. the fields cannot be set by an user either as they are always initialized with some default values. I expected that `minimum_{algorithm,key_len}` were going be used to check that the keys in `TrustAnchor` meet those minimums and the `TrustAnchor` would be rejected if none of its keys met the criteria but that does not seem to be the case should the fields be removed or are they planned to be used later on?