[PR #937] [MERGED] Partially eliminate use of `extern crate` #1802

New issue

Closed

opened 2026-03-16 02:26:26 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:26:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/937
Author: @rotty
Created: 12/1/2019
Status: ✅ Merged
Merged: 12/3/2019
Merged by: @bluejekyll

Base: master ← Head: no-extern-crate

📝 Commits (3)

254fac0 proto: Eliminate use of extern crate
e453c33 util: Eliminate use of extern crate
6dd08ff client: Eliminate use of extern crate

📊 Changes

53 files changed (+107 additions, -167 deletions)

View changed files

📝 crates/client/benches/lower_name_benches.rs (+0 -2)
📝 crates/client/src/client/client.rs (+4 -2)
📝 crates/client/src/client/client_connection.rs (+4 -2)
📝 crates/client/src/client/client_future.rs (+4 -3)
📝 crates/client/src/client/memoize_client_handle.rs (+8 -4)
📝 crates/client/src/client/mod.rs (+4 -4)
📝 crates/client/src/error/client_error.rs (+1 -1)
📝 crates/client/src/error/dnssec_error.rs (+1 -1)
📝 crates/client/src/error/parse_error.rs (+1 -1)
📝 crates/client/src/https_client_connection.rs (+1 -1)
📝 crates/client/src/lib.rs (+2 -47)
📝 crates/client/src/multicast/mdns_client_connection.rs (+4 -2)
📝 crates/client/src/multicast/mod.rs (+1 -1)
📝 crates/client/src/op/lower_query.rs (+1 -1)
📝 crates/client/src/op/mod.rs (+3 -3)
📝 crates/client/src/rr/dnssec/mod.rs (+1 -1)
📝 crates/client/src/rr/dnssec/signer.rs (+7 -9)
📝 crates/client/src/rr/lower_name.rs (+1 -1)
📝 crates/client/src/rr/mod.rs (+8 -8)
📝 crates/client/src/rr/zone.rs (+4 -3)

...and 33 more files

📄 Description

This eliminates the use of extern crate for the proto and client
crates, as well as the util directory, including a reference in the
client top-level API docs.

I hope to come around to provide patches to get rid of extern crate
in the rest of the codebase as well, but I'm not sure when I'll get
around to it. This branch has been sitting here for a while, so I
decided I should send out what I have, even if it's not complete.

I'll either update this PR with further extern crate patches, or, in
case it gets merged before I get around to do that, open a new PR.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/937 **Author:** [@rotty](https://github.com/rotty) **Created:** 12/1/2019 **Status:** ✅ Merged **Merged:** 12/3/2019 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `no-extern-crate` --- ### 📝 Commits (3) - [`254fac0`](https://github.com/hickory-dns/hickory-dns/commit/254fac0041616dfe1634fc181586db957df0bef5) proto: Eliminate use of `extern crate` - [`e453c33`](https://github.com/hickory-dns/hickory-dns/commit/e453c33563f2542ac624774e690f08408f796b56) util: Eliminate use of `extern crate` - [`6dd08ff`](https://github.com/hickory-dns/hickory-dns/commit/6dd08ff9d4b736162de25a76915b0517462aac5c) client: Eliminate use of `extern crate` ### 📊 Changes **53 files changed** (+107 additions, -167 deletions) <details> <summary>View changed files</summary> 📝 `crates/client/benches/lower_name_benches.rs` (+0 -2) 📝 `crates/client/src/client/client.rs` (+4 -2) 📝 `crates/client/src/client/client_connection.rs` (+4 -2) 📝 `crates/client/src/client/client_future.rs` (+4 -3) 📝 `crates/client/src/client/memoize_client_handle.rs` (+8 -4) 📝 `crates/client/src/client/mod.rs` (+4 -4) 📝 `crates/client/src/error/client_error.rs` (+1 -1) 📝 `crates/client/src/error/dnssec_error.rs` (+1 -1) 📝 `crates/client/src/error/parse_error.rs` (+1 -1) 📝 `crates/client/src/https_client_connection.rs` (+1 -1) 📝 `crates/client/src/lib.rs` (+2 -47) 📝 `crates/client/src/multicast/mdns_client_connection.rs` (+4 -2) 📝 `crates/client/src/multicast/mod.rs` (+1 -1) 📝 `crates/client/src/op/lower_query.rs` (+1 -1) 📝 `crates/client/src/op/mod.rs` (+3 -3) 📝 `crates/client/src/rr/dnssec/mod.rs` (+1 -1) 📝 `crates/client/src/rr/dnssec/signer.rs` (+7 -9) 📝 `crates/client/src/rr/lower_name.rs` (+1 -1) 📝 `crates/client/src/rr/mod.rs` (+8 -8) 📝 `crates/client/src/rr/zone.rs` (+4 -3) _...and 33 more files_ </details> ### 📄 Description This eliminates the use of `extern crate` for the `proto` and `client` crates, as well as the `util` directory, including a reference in the `client` top-level API docs. --- I hope to come around to provide patches to get rid of `extern crate` in the rest of the codebase as well, but I'm not sure when I'll get around to it. This branch has been sitting here for a while, so I decided I should send out what I have, even if it's not complete. I'll either update this PR with further `extern crate` patches, or, in case it gets merged before I get around to do that, open a new PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>