mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 11:15:54 +03:00
[GH-ISSUE #2046] Unable to build without linking against libssl/libcrypt #861
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#861
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @cbgbt on GitHub (Oct 4, 2023).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2046
Describe the bug
Even with a minimal set of features enabled, binaries still link against
libsslandlibcrypt.To Reproduce
Steps to reproduce the behavior:
This fails to build if openssl lib/headers aren't installed, and produces a binary that dynamically links against them if they are.
Expected behavior
I anticipated that this would successfully build on a system without openssl dynamic libraries and headers.
Version:
Version: 0.23.0
Additional context
I believe, though haven't confirmed, that this is due to unconditional openssl dependencies in the workspace root (e.g.).
I'm happy to look into conditionalizing this, I just wasn't sure if I was missing something.
@cbgbt commented on GitHub (Oct 4, 2023):
I went to take a look at this and realized that it's actually not true of the
mainbranch. I haven't worked out why that is yet, but this issue isn't necessary. Thanks!@djc commented on GitHub (Oct 4, 2023):
This is building the binary? There may be some incorrect dependency edges that got cleaned up in #2028.