[PR #1158] [MERGED] Support mDNS unicast-response bit #2028

New issue

Closed

opened 2026-03-16 04:57:32 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 04:57:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1158
Author: @fluxxu
Created: 6/29/2020
Status: ✅ Merged
Merged: 7/7/2020
Merged by: @bluejekyll

Base: main ← Head: main

📝 Commits (2)

b43d72a Support mDNS unicast-response bit
83198d3 Merge branch 'main' into main

📊 Changes

1 file changed (+104 additions, -5 deletions)

View changed files

📝 crates/proto/src/op/query.rs (+104 -5)

📄 Description

This is a follow up to
https://github.com/bluejekyll/trust-dns/pull/1144
I found another bit that needs special handling.

https://tools.ietf.org/html/rfc6762#section-5.4

   To avoid large floods of potentially unnecessary responses in these
   cases, Multicast DNS defines the top bit in the class field of a DNS
   question as the unicast-response bit.  When this bit is set in a
   question, it indicates that the querier is willing to accept unicast
   replies in response to this specific query, as well as the usual
   multicast responses.  These questions requesting unicast responses
   are referred to as "QU" questions, to distinguish them from the more
   usual questions requesting multicast responses ("QM" questions).  A
   Multicast DNS querier sending its initial batch of questions
   immediately on wake from sleep or interface activation SHOULD set the
   unicast-response bit in those questions.

Thanks!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1158 **Author:** [@fluxxu](https://github.com/fluxxu) **Created:** 6/29/2020 **Status:** ✅ Merged **Merged:** 7/7/2020 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`b43d72a`](https://github.com/hickory-dns/hickory-dns/commit/b43d72af3f3cc458ccfd0fa219a44a3501bddee9) Support mDNS unicast-response bit - [`83198d3`](https://github.com/hickory-dns/hickory-dns/commit/83198d3078f632c3a726d057e74e498bdb84faac) Merge branch 'main' into main ### 📊 Changes **1 file changed** (+104 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/op/query.rs` (+104 -5) </details> ### 📄 Description This is a follow up to https://github.com/bluejekyll/trust-dns/pull/1144 I found another bit that needs special handling. https://tools.ietf.org/html/rfc6762#section-5.4 ``` To avoid large floods of potentially unnecessary responses in these cases, Multicast DNS defines the top bit in the class field of a DNS question as the unicast-response bit. When this bit is set in a question, it indicates that the querier is willing to accept unicast replies in response to this specific query, as well as the usual multicast responses. These questions requesting unicast responses are referred to as "QU" questions, to distinguish them from the more usual questions requesting multicast responses ("QM" questions). A Multicast DNS querier sending its initial batch of questions immediately on wake from sleep or interface activation SHOULD set the unicast-response bit in those questions. ``` Thanks! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>