[GH-ISSUE #958] Make tokio crate optional for trust-dns-proto #574

New issue

Closed

opened 2026-03-15 23:15:11 +03:00 by kerem · 2 comments

kerem commented

2026-03-15 23:15:11 +03:00

Owner

Originally created by @chunyingw on GitHub (Dec 16, 2019).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/958

Hey Ben,

It seems Fuchsia prefers to make the tokio crate optional. I am taking the effort to make that happen for trust-dns-proto by moving from

tokio::io::{AsyncRead, AsyncWrite} to std::io::{AsyncRead, AsyncWrite}
Abstract tokio::time::{Timeout, Delay}.

So far I am able to build/run/test trust-dns-proto successfully and run the unit tests using Fuchsia's timer, executor on Fuchsia successfully.

I am going to modify other crates which are impacted because of the interface changes.
Does it sound okay for you?

Originally created by @chunyingw on GitHub (Dec 16, 2019). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/958 Hey Ben, It seems Fuchsia prefers to make the tokio crate optional. I am taking the effort to make that happen for trust-dns-proto by moving from 1. tokio::io::{AsyncRead, AsyncWrite} to std::io::{AsyncRead, AsyncWrite} 2. Abstract tokio::time::{Timeout, Delay}. So far I am able to build/run/test trust-dns-proto successfully and run the unit tests using Fuchsia's timer, executor on Fuchsia successfully. I am going to modify other crates which are impacted because of the interface changes. Does it sound okay for you?

kerem closed this issue

2026-03-15 23:15:17 +03:00

kerem commented

2026-03-15 23:15:22 +03:00

Author

Owner

@bluejekyll commented on GitHub (Dec 16, 2019):

I am going to modify other crates which are impacted because of the interface changes.
Does it sound okay for you?

Yes, though:

std::io::{AsyncRead, AsyncWrite}

I think you mean futures::io::{AsyncRead, AsyncWrite}, as there aren't std definitions for these. I didn't realize those worked with Tokio already. That's great news.

So far I am able to build/run/test trust-dns-proto successfully and run the unit tests using Fuchsia's timer, executor on Fuchsia successfully.

That's fantastic!

@bluejekyll commented on GitHub (Dec 16, 2019): > I am going to modify other crates which are impacted because of the interface changes. Does it sound okay for you? Yes, though: > std::io::{AsyncRead, AsyncWrite} I think you mean `futures::io::{AsyncRead, AsyncWrite}`, as there aren't std definitions for these. I didn't realize those worked with Tokio already. That's great news. > So far I am able to build/run/test trust-dns-proto successfully and run the unit tests using Fuchsia's timer, executor on Fuchsia successfully. That's fantastic!

kerem commented

2026-03-15 23:15:27 +03:00

Author

Owner

@chunyingw commented on GitHub (Dec 16, 2019):

I am going to modify other crates which are impacted because of the interface changes.
Does it sound okay for you?

Yes, though:

std::io::{AsyncRead, AsyncWrite}

I think you mean futures::io::{AsyncRead, AsyncWrite}, as there aren't std definitions for these. I didn't realize those worked with Tokio already. That's great news.
You are absolutely right. It's it's futures:io::{AsyncRead, AsyncWrite}. I use a new type like DnsTokioTcpStream(TokioTcpStream) to achieve this. It's not transparent.

So far I am able to build/run/test trust-dns-proto successfully and run the unit tests using Fuchsia's timer, executor on Fuchsia successfully.

That's fantastic!

@chunyingw commented on GitHub (Dec 16, 2019): > > I am going to modify other crates which are impacted because of the interface changes. > > Does it sound okay for you? > > Yes, though: > > > std::io::{AsyncRead, AsyncWrite} > > I think you mean `futures::io::{AsyncRead, AsyncWrite}`, as there aren't std definitions for these. I didn't realize those worked with Tokio already. That's great news. You are absolutely right. It's it's futures:io::{AsyncRead, AsyncWrite}. I use a new type like DnsTokioTcpStream(TokioTcpStream) to achieve this. It's not transparent. > > > So far I am able to build/run/test trust-dns-proto successfully and run the unit tests using Fuchsia's timer, executor on Fuchsia successfully. > > That's fantastic!

kerem referenced this issue

2026-03-16 02:11:06 +03:00

[PR #574] [CLOSED] makes the IDNA library optional #1523