[PR #574] [CLOSED] makes the IDNA library optional #1523

New issue

Closed

opened 2026-03-16 02:11:06 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:11:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/574
Author: @bluejekyll
Created: 10/8/2018
Status: ❌ Closed

Base: master ← Head: optional-idna

📝 Commits (1)

66053ad makes the IDNA library optional, this will disable utf8 and i18n support

📊 Changes

4 files changed (+286 additions, -98 deletions)

View changed files

📝 proto/Cargo.toml (+3 -1)
📝 proto/src/lib.rs (+1 -0)
📝 proto/src/rr/domain/label.rs (+62 -26)
📝 proto/src/rr/domain/name.rs (+220 -71)

📄 Description

this will disable utf8 and i18n support

fixes: #551

@aep if you have some time, please take a look at this. This will disable all i18n support, so it will be the responsibility of any library that needs that to encode the labels correctly.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/574 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 10/8/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `optional-idna` --- ### 📝 Commits (1) - [`66053ad`](https://github.com/hickory-dns/hickory-dns/commit/66053ad4e09b1c3f16a9443a07b3f1535bc847f7) makes the IDNA library optional, this will disable utf8 and i18n support ### 📊 Changes **4 files changed** (+286 additions, -98 deletions) <details> <summary>View changed files</summary> 📝 `proto/Cargo.toml` (+3 -1) 📝 `proto/src/lib.rs` (+1 -0) 📝 `proto/src/rr/domain/label.rs` (+62 -26) 📝 `proto/src/rr/domain/name.rs` (+220 -71) </details> ### 📄 Description this will disable utf8 and i18n support fixes: #551 @aep if you have some time, please take a look at this. This will disable all i18n support, so it will be the responsibility of any library that needs that to encode the labels correctly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>