starred/hickory-dns

Fork 0

mirror of https://github.com/hickory-dns/hickory-dns.git synced 2026-04-25 03:05:51 +03:00

[GH-ISSUE #314] failure to parse a valid zone file #440

New issue

Closed

opened 2026-03-15 22:29:48 +03:00 by kerem · 9 comments

kerem commented

2026-03-15 22:29:48 +03:00

Owner

Originally created by @little-dude on GitHub (Dec 14, 2017).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/314

I'm taking a look at deckard as suggested in https://github.com/bluejekyll/trust-dns/issues/219, and the server tests are failing because trust-dns fails to parse this zone file:

$ORIGIN example.com.
$TTL 3600

@	SOA	dns1.example.com. hostmaster.example.com. (
		2010111213	; serial
		6h		; refresh
		1h		; retry
		1w		; expire
		1d )		; minimum

	NS	dns1
	NS	dns2
	MX	10 mail

dns1	A	192.0.2.1
	AAAA	2001:DB8::1

dns2	A	192.0.2.2
	AAAA	2001:DB8::2

mail	A	192.0.2.3
	AAAA	2001:DB8::3

There are two issues:

the parser does not support the specifiying times with letters such as 6h, 2w or 1d.
the parser does not support implicit record class, you have to explicitely set it to IN

Originally created by @little-dude on GitHub (Dec 14, 2017). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/314 I'm taking a look at deckard as suggested in https://github.com/bluejekyll/trust-dns/issues/219, and the server tests are failing because trust-dns fails to parse this zone file: ``` $ORIGIN example.com. $TTL 3600 @ SOA dns1.example.com. hostmaster.example.com. ( 2010111213 ; serial 6h ; refresh 1h ; retry 1w ; expire 1d ) ; minimum NS dns1 NS dns2 MX 10 mail dns1 A 192.0.2.1 AAAA 2001:DB8::1 dns2 A 192.0.2.2 AAAA 2001:DB8::2 mail A 192.0.2.3 AAAA 2001:DB8::3 ``` There are two issues: - the parser does not support the specifiying times with letters such as `6h`, `2w` or `1d`. - the parser does not support implicit record class, you have to explicitely set it to `IN`

kerem

2026-03-15 22:29:48 +03:00

closed this issue
added the
bug

crate:client

crate:server
labels

kerem commented

2026-03-15 22:30:04 +03:00

Author

Owner

@bluejekyll commented on GitHub (Dec 15, 2017):

the parser does not support the specifiying times with letters such as 6h, 2w or 1d

This one surprises me, because I know I added support for it, we should add a test case for that specifically:

https://github.com/bluejekyll/trust-dns/blob/master/client/src/serialize/txt/master.rs#L385-L423

Edit: after reviewing the code, I realize what the problem is, it's specifically in the SOA record that this support wasn't added, we need call back the method I linked above:

https://github.com/bluejekyll/trust-dns/blob/master/client/src/serialize/txt/rdata_parsers/soa.rs#L46-L72

the parser does not support implicit record class, you have to explicitely set it to IN

We can default to IN, I don't have a problem with that. It's been a while since I looked at this code, but I think the default is set to the last Record seen, so it should be as simple as setting this to Some(DNSClass::IN) instead of None:

https://github.com/bluejekyll/trust-dns/blob/master/client/src/serialize/txt/master.rs#L150

@bluejekyll commented on GitHub (Dec 15, 2017): > the parser does not support the specifiying times with letters such as 6h, 2w or 1d This one surprises me, because I know I added support for it, we should add a test case for that specifically: https://github.com/bluejekyll/trust-dns/blob/master/client/src/serialize/txt/master.rs#L385-L423 Edit: after reviewing the code, I realize what the problem is, it's specifically in the SOA record that this support wasn't added, we need call back the method I linked above: https://github.com/bluejekyll/trust-dns/blob/master/client/src/serialize/txt/rdata_parsers/soa.rs#L46-L72 > the parser does not support implicit record class, you have to explicitely set it to IN We can default to IN, I don't have a problem with that. It's been a while since I looked at this code, but I think the default is set to the last Record seen, so it should be as simple as setting this to `Some(DNSClass::IN)` instead of `None`: https://github.com/bluejekyll/trust-dns/blob/master/client/src/serialize/txt/master.rs#L150

kerem commented

2026-03-15 22:30:09 +03:00

Author

Owner

@davepacheco commented on GitHub (Mar 2, 2022):

In case it's helpful to anyone else, the error message I saw was:

Error { kind: ParseInt(ParseIntError { kind: InvalidDigit }) }', bin/src/named.rs:405:27

This issue helped me find the problem (using times like "1h" in the SOA record) and work around it. Thanks!

@davepacheco commented on GitHub (Mar 2, 2022): In case it's helpful to anyone else, the error message I saw was: ``` Error { kind: ParseInt(ParseIntError { kind: InvalidDigit }) }', bin/src/named.rs:405:27 ``` This issue helped me find the problem (using times like "1h" in the SOA record) and work around it. Thanks!

kerem commented

2026-03-15 22:30:14 +03:00

Author

Owner

@bluejekyll commented on GitHub (Mar 3, 2022):

Which version of trust-dns did you experience this with @davepacheco?

@bluejekyll commented on GitHub (Mar 3, 2022): Which version of trust-dns did you experience this with @davepacheco?

kerem commented

2026-03-15 22:30:19 +03:00

Author

Owner

@davepacheco commented on GitHub (Mar 3, 2022):

I cloned the default branch and built it yesterday. I was on commit 8515a4321f.

@davepacheco commented on GitHub (Mar 3, 2022): I cloned the default branch and built it yesterday. I was on commit 8515a4321f796aaccc84ed1c3954e3f302941d9f.

kerem commented

2026-03-15 22:30:24 +03:00

Author

Owner

@bluejekyll commented on GitHub (Mar 3, 2022):

And was the lack of IN on the records the issue that triggered this for you?

@bluejekyll commented on GitHub (Mar 3, 2022): And was the lack of `IN` on the records the issue that triggered this for you?

kerem commented

2026-03-15 22:30:29 +03:00

Author

Owner

@bluejekyll commented on GitHub (Mar 3, 2022):

i.e. if we use the above config as a reference, would that cover your use case as well?

@bluejekyll commented on GitHub (Mar 3, 2022): i.e. if we use the above config as a reference, would that cover your use case as well?

kerem commented

2026-03-15 22:30:34 +03:00

Author

Owner

@davepacheco commented on GitHub (Mar 3, 2022):

It appeared to be the use of human-readable times (like "1h") that did it. When I changed all of those to an integer number of seconds, it worked. When I changed any of them back, I got that error.

(edit: sorry for the ambiguity earlier -- I see there were two issues described here and I zero'd in on the one I hit, related to human-readable time strings)

@davepacheco commented on GitHub (Mar 3, 2022): It appeared to be the use of human-readable times (like "1h") that did it. When I changed all of those to an integer number of seconds, it worked. When I changed any of them back, I got that error. (edit: sorry for the ambiguity earlier -- I see there were two issues described here and I zero'd in on the one I hit, related to human-readable time strings)

kerem commented

2026-03-15 22:30:39 +03:00

Author

Owner

@bluejekyll commented on GitHub (Mar 3, 2022):

Ok. And in the SOA record specifically it sounds like? I’ll get that fixed.

@bluejekyll commented on GitHub (Mar 3, 2022): Ok. And in the SOA record specifically it sounds like? I’ll get that fixed.

kerem commented

2026-03-15 22:30:44 +03:00

Author

Owner

@davepacheco commented on GitHub (Mar 4, 2022):

Yup, it was in the SOA record.

@davepacheco commented on GitHub (Mar 4, 2022): Yup, it was in the SOA record.

kerem referenced this issue

2026-03-16 02:06:29 +03:00

[PR #440] [CLOSED] More tokio clenaups #1437

kerem referenced this issue

2026-03-16 02:06:45 +03:00