[PR #446] [MERGED] Port away from tokio_core::reactor::Core #1444

New issue

Closed

opened 2026-03-16 02:06:45 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:06:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/446
Author: @Keruspe
Created: 5/3/2018
Status: ✅ Merged
Merged: 5/4/2018
Merged by: @bluejekyll

Base: master ← Head: nocore

📝 Commits (10+)

7775983 proto: switch back to tokio_executor::spawn
f4dec96 resolver: fix some tests
4d27a6e resolver: fix tests
ceb7a5e make ClientFuture::new return a Future
9e032f7 fix integration tests
4aa0b7f update tokio
b6b8570 start porting away frmo tokio_core::reactor::Core
c22c483 client: port away from tokio_core::reactor::Core
562f7b1 proto: port away from tokio_core::reactor::Core
93bb9f4 resolver: port away from tokio_core::reactor::Core

📊 Changes

47 files changed (+767 additions, -625 deletions)

View changed files

📝 Cargo.lock (+35 -22)
📝 client/Cargo.toml (+1 -1)
📝 client/src/client/client.rs (+53 -41)
📝 client/src/client/client_future.rs (+15 -13)
📝 client/src/lib.rs (+1 -1)
📝 integration-tests/Cargo.toml (+1 -1)
📝 integration-tests/src/lib.rs (+1 -1)
📝 integration-tests/tests/client_future_tests.rs (+115 -106)
📝 integration-tests/tests/client_tests.rs (+0 -1)
📝 integration-tests/tests/lookup_tests.rs (+41 -31)
📝 integration-tests/tests/mdns_tests.rs (+13 -11)
📝 integration-tests/tests/name_server_pool_tests.rs (+10 -10)
📝 integration-tests/tests/secure_client_handle_tests.rs (+21 -18)
📝 integration-tests/tests/server_future_tests.rs (+34 -19)
📝 native-tls/Cargo.toml (+1 -1)
📝 native-tls/src/lib.rs (+1 -1)
📝 native-tls/src/tests.rs (+5 -5)
📝 openssl/Cargo.toml (+1 -1)
📝 openssl/tests/openssl_tests.rs (+6 -6)
📝 proto/Cargo.toml (+2 -2)

...and 27 more files

📄 Description

Fixes #385
Based on #440

Everything but server and integration-tests is ported

Let's see what the CI has to say

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/446 **Author:** [@Keruspe](https://github.com/Keruspe) **Created:** 5/3/2018 **Status:** ✅ Merged **Merged:** 5/4/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `nocore` --- ### 📝 Commits (10+) - [`7775983`](https://github.com/hickory-dns/hickory-dns/commit/77759834dc734cb74a8e8b616a4ea078b29fca48) proto: switch back to tokio_executor::spawn - [`f4dec96`](https://github.com/hickory-dns/hickory-dns/commit/f4dec9617b9c97185d64eb0c00f3957147a93d9d) resolver: fix some tests - [`4d27a6e`](https://github.com/hickory-dns/hickory-dns/commit/4d27a6e4bbda250873349007121eba35337f7e76) resolver: fix tests - [`ceb7a5e`](https://github.com/hickory-dns/hickory-dns/commit/ceb7a5e66a539bf25a613aa0e3f5986ecaed9d59) make ClientFuture::new return a Future - [`9e032f7`](https://github.com/hickory-dns/hickory-dns/commit/9e032f74b6e4d3a15dc2a332d8f257c7449ec5e5) fix integration tests - [`4aa0b7f`](https://github.com/hickory-dns/hickory-dns/commit/4aa0b7f58ab221d75140f87fca663eeafe255937) update tokio - [`b6b8570`](https://github.com/hickory-dns/hickory-dns/commit/b6b85703c5c91c32ce76a4d73821e33f1b2aaf62) start porting away frmo tokio_core::reactor::Core - [`c22c483`](https://github.com/hickory-dns/hickory-dns/commit/c22c4834f9a4b995369d28bc0b147ed391fa9017) client: port away from tokio_core::reactor::Core - [`562f7b1`](https://github.com/hickory-dns/hickory-dns/commit/562f7b1d0916e83604bde41366df617982317243) proto: port away from tokio_core::reactor::Core - [`93bb9f4`](https://github.com/hickory-dns/hickory-dns/commit/93bb9f4a5cdd3a5dc51a3116711830e412f6d752) resolver: port away from tokio_core::reactor::Core ### 📊 Changes **47 files changed** (+767 additions, -625 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+35 -22) 📝 `client/Cargo.toml` (+1 -1) 📝 `client/src/client/client.rs` (+53 -41) 📝 `client/src/client/client_future.rs` (+15 -13) 📝 `client/src/lib.rs` (+1 -1) 📝 `integration-tests/Cargo.toml` (+1 -1) 📝 `integration-tests/src/lib.rs` (+1 -1) 📝 `integration-tests/tests/client_future_tests.rs` (+115 -106) 📝 `integration-tests/tests/client_tests.rs` (+0 -1) 📝 `integration-tests/tests/lookup_tests.rs` (+41 -31) 📝 `integration-tests/tests/mdns_tests.rs` (+13 -11) 📝 `integration-tests/tests/name_server_pool_tests.rs` (+10 -10) 📝 `integration-tests/tests/secure_client_handle_tests.rs` (+21 -18) 📝 `integration-tests/tests/server_future_tests.rs` (+34 -19) 📝 `native-tls/Cargo.toml` (+1 -1) 📝 `native-tls/src/lib.rs` (+1 -1) 📝 `native-tls/src/tests.rs` (+5 -5) 📝 `openssl/Cargo.toml` (+1 -1) 📝 `openssl/tests/openssl_tests.rs` (+6 -6) 📝 `proto/Cargo.toml` (+2 -2) _...and 27 more files_ </details> ### 📄 Description Fixes #385 Based on #440 Everything but server and integration-tests is ported Let's see what the CI has to say --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>