[PR #3403] [MERGED] net: simplify message exchange utilities #3812

New issue

Closed

opened 2026-03-16 12:04:02 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 12:04:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3403
Author: @djc
Created: 12/17/2025
Status: ✅ Merged
Merged: 1/4/2026
Merged by: @djc

Base: main ← Head: simplify-xfer

📝 Commits (10+)

b59b8da net: drop unnecessary DnsExchangeConnectInner state
da6f5d4 net: use ready!() macro to simplify Future impl
fece78f net: avoid restating DnsRequestSender bounds
eb538da net: UDP clients don't need to connect
1d8f165 net: drop Display bound for DnsClientStream
7a65fa9 net: avoid restating DnsClientStream bounds
3f5e74c net: drop trivial mDNS connection future wrapper
dac8bb4 net: drop trivial HttpsClientConnect future wrapper
aac6da9 net: drop trivial QUIC future wrappers
1417863 net: drop trivial H3 future wrappers

📊 Changes

52 files changed (+968 additions, -1402 deletions)

View changed files

📝 bin/benches/comparison_benches.rs (+13 -16)
📝 bin/src/config/mod.rs (+1 -1)
📝 bin/tests/integration/named_https_tests.rs (+8 -9)
📝 bin/tests/integration/named_metrics_tests.rs (+2 -3)
📝 bin/tests/integration/named_quic_tests.rs (+6 -6)
📝 bin/tests/integration/named_rustls_tests.rs (+7 -10)
📝 bin/tests/integration/named_test_rsa_dnssec.rs (+2 -4)
📝 bin/tests/integration/named_tests.rs (+67 -67)
📝 conformance/e2e-tests/src/client.rs (+2 -1)
📝 conformance/test-server/src/main.rs (+5 -8)
📝 crates/net/src/client/dnssec_client.rs (+9 -6)
📝 crates/net/src/client/mod.rs (+25 -32)
📝 crates/net/src/client/tests.rs (+3 -6)
📝 crates/net/src/h2/h2_client_stream.rs (+207 -225)
📝 crates/net/src/h2/mod.rs (+1 -1)
📝 crates/net/src/h3/h3_client_stream.rs (+25 -34)
📝 crates/net/src/h3/h3_server.rs (+1 -1)
📝 crates/net/src/h3/mod.rs (+1 -3)
📝 crates/net/src/lib.rs (+2 -2)
📝 crates/net/src/multicast/mdns_client_stream.rs (+22 -34)

...and 32 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3403 **Author:** [@djc](https://github.com/djc) **Created:** 12/17/2025 **Status:** ✅ Merged **Merged:** 1/4/2026 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `simplify-xfer` --- ### 📝 Commits (10+) - [`b59b8da`](https://github.com/hickory-dns/hickory-dns/commit/b59b8daf93e0c5c00a670c1c709be567ca0a4adb) net: drop unnecessary DnsExchangeConnectInner state - [`da6f5d4`](https://github.com/hickory-dns/hickory-dns/commit/da6f5d4340610d3aeb1750c1f03a55b2f271aafe) net: use ready!() macro to simplify Future impl - [`fece78f`](https://github.com/hickory-dns/hickory-dns/commit/fece78f8ae00f46c3889c85e393c44a09106a353) net: avoid restating DnsRequestSender bounds - [`eb538da`](https://github.com/hickory-dns/hickory-dns/commit/eb538da09cfff944e0ed0ca1ad9cc66ddd35917d) net: UDP clients don't need to connect - [`1d8f165`](https://github.com/hickory-dns/hickory-dns/commit/1d8f1650fcfd01732057a50181ad7d468b016f1d) net: drop Display bound for DnsClientStream - [`7a65fa9`](https://github.com/hickory-dns/hickory-dns/commit/7a65fa95d382c908530ba116885fd062c8201e7e) net: avoid restating DnsClientStream bounds - [`3f5e74c`](https://github.com/hickory-dns/hickory-dns/commit/3f5e74cb6d1f5eb17120c94d96416f9b4b9da76e) net: drop trivial mDNS connection future wrapper - [`dac8bb4`](https://github.com/hickory-dns/hickory-dns/commit/dac8bb4ee863219cf89cc3c5c2338238ef083e54) net: drop trivial HttpsClientConnect future wrapper - [`aac6da9`](https://github.com/hickory-dns/hickory-dns/commit/aac6da9587feb4a369448a8096f2cf6170026a90) net: drop trivial QUIC future wrappers - [`1417863`](https://github.com/hickory-dns/hickory-dns/commit/1417863a2b39a979e8a1d8b9c698b9dc427d414f) net: drop trivial H3 future wrappers ### 📊 Changes **52 files changed** (+968 additions, -1402 deletions) <details> <summary>View changed files</summary> 📝 `bin/benches/comparison_benches.rs` (+13 -16) 📝 `bin/src/config/mod.rs` (+1 -1) 📝 `bin/tests/integration/named_https_tests.rs` (+8 -9) 📝 `bin/tests/integration/named_metrics_tests.rs` (+2 -3) 📝 `bin/tests/integration/named_quic_tests.rs` (+6 -6) 📝 `bin/tests/integration/named_rustls_tests.rs` (+7 -10) 📝 `bin/tests/integration/named_test_rsa_dnssec.rs` (+2 -4) 📝 `bin/tests/integration/named_tests.rs` (+67 -67) 📝 `conformance/e2e-tests/src/client.rs` (+2 -1) 📝 `conformance/test-server/src/main.rs` (+5 -8) 📝 `crates/net/src/client/dnssec_client.rs` (+9 -6) 📝 `crates/net/src/client/mod.rs` (+25 -32) 📝 `crates/net/src/client/tests.rs` (+3 -6) 📝 `crates/net/src/h2/h2_client_stream.rs` (+207 -225) 📝 `crates/net/src/h2/mod.rs` (+1 -1) 📝 `crates/net/src/h3/h3_client_stream.rs` (+25 -34) 📝 `crates/net/src/h3/h3_server.rs` (+1 -1) 📝 `crates/net/src/h3/mod.rs` (+1 -3) 📝 `crates/net/src/lib.rs` (+2 -2) 📝 `crates/net/src/multicast/mdns_client_stream.rs` (+22 -34) _...and 32 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>