[PR #2887] [MERGED] proto: set FQDN to true in zone file parser #3403

New issue

Closed

opened 2026-03-16 11:41:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:41:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2887
Author: @djc
Created: 3/25/2025
Status: ✅ Merged
Merged: 3/25/2025
Merged by: @djc

Base: main ← Head: fqdn-zone

📝 Commits (8)

0c67f12 proto: extract Context type from Parser
861e9ea proto: move Parser::flush_record() to Context::insert()
77ec463 proto: simplify insert() error handling
84084f7 proto: flatten match arms
e8a7a6d proto: flatten match arms some more
2bb993d proto: flatten match arms for record insertion
4fe9e0c proto: simplify record creation
7521226 proto: set FQDN to true in zone file parser

📊 Changes

1 file changed (+107 additions, -112 deletions)

View changed files

📝 crates/proto/src/serialize/txt/zone.rs (+107 -112)

📄 Description

Also, a bunch of refactoring to clean it up a bit.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2887 **Author:** [@djc](https://github.com/djc) **Created:** 3/25/2025 **Status:** ✅ Merged **Merged:** 3/25/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `fqdn-zone` --- ### 📝 Commits (8) - [`0c67f12`](https://github.com/hickory-dns/hickory-dns/commit/0c67f1253979538185da80a64b2bc617a543e2aa) proto: extract Context type from Parser - [`861e9ea`](https://github.com/hickory-dns/hickory-dns/commit/861e9ea86242a8cf81a038f6a41f26f853841a5c) proto: move Parser::flush_record() to Context::insert() - [`77ec463`](https://github.com/hickory-dns/hickory-dns/commit/77ec463a843c7edcd13daa74e12836c02c6f0c65) proto: simplify insert() error handling - [`84084f7`](https://github.com/hickory-dns/hickory-dns/commit/84084f78f570f4c4e04237333c584e637b644a12) proto: flatten match arms - [`e8a7a6d`](https://github.com/hickory-dns/hickory-dns/commit/e8a7a6d76cbb1819aaac2cc8b8dc8b1d9cc35094) proto: flatten match arms some more - [`2bb993d`](https://github.com/hickory-dns/hickory-dns/commit/2bb993d128a4f55177e6d5efa0e061ae728abc31) proto: flatten match arms for record insertion - [`4fe9e0c`](https://github.com/hickory-dns/hickory-dns/commit/4fe9e0cd37e5140f3bda51602ddeb25591375413) proto: simplify record creation - [`7521226`](https://github.com/hickory-dns/hickory-dns/commit/7521226c1998afee0a896f8af91df599de161beb) proto: set FQDN to true in zone file parser ### 📊 Changes **1 file changed** (+107 additions, -112 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/serialize/txt/zone.rs` (+107 -112) </details> ### 📄 Description Also, a bunch of refactoring to clean it up a bit. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>