[PR #3402] [MERGED] Simplify runtime #3810

New issue

Closed

opened 2026-03-16 12:04:02 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 12:04:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/3402
Author: @djc
Created: 12/16/2025
Status: ✅ Merged
Merged: 12/18/2025
Merged by: @djc

Base: main ← Head: simplify-runtime

📝 Commits (5)

36b4db4 net: revert RuntimeProvider trait to yielding io errors
af34b4a net: spawn_bg() doesn't handle errors
943201a net: move DnsTcpStream into runtime
3619ee8 net: move DnsUdpSocket into runtime
8b81b3a net: drop test-only Executor abstraction

📊 Changes

17 files changed (+138 additions, -178 deletions)

View changed files

📝 crates/net/src/h2/h2_client_stream.rs (+3 -3)
📝 crates/net/src/runtime.rs (+66 -45)
📝 crates/net/src/rustls/tls_client_stream.rs (+6 -9)
📝 crates/net/src/rustls/tls_stream.rs (+7 -10)
📝 crates/net/src/tcp/mod.rs (+1 -1)
📝 crates/net/src/tcp/tcp_client_stream.rs (+2 -2)
📝 crates/net/src/tcp/tcp_stream.rs (+2 -8)
📝 crates/net/src/udp/mod.rs (+1 -1)
📝 crates/net/src/udp/udp_client_stream.rs (+2 -2)
📝 crates/net/src/udp/udp_stream.rs (+3 -42)
📝 crates/net/src/xfer/dns_exchange.rs (+3 -5)
📝 crates/resolver/examples/custom_provider.rs (+10 -9)
📝 crates/resolver/src/name_server.rs (+14 -17)
📝 crates/resolver/src/name_server_pool.rs (+1 -1)
📝 crates/resolver/src/resolver.rs (+11 -11)
📝 tests/integration-tests/src/mock_client.rs (+3 -6)
📝 tests/test-support/src/lib.rs (+3 -6)

📄 Description

Here's some work towards the hickory-tokio crate split as discussed in

#3313

I don't think that split works out as I thought, will comment in that issue.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/3402 **Author:** [@djc](https://github.com/djc) **Created:** 12/16/2025 **Status:** ✅ Merged **Merged:** 12/18/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `simplify-runtime` --- ### 📝 Commits (5) - [`36b4db4`](https://github.com/hickory-dns/hickory-dns/commit/36b4db4972491c3b0fa612e5cacfe504abb8bb55) net: revert RuntimeProvider trait to yielding io errors - [`af34b4a`](https://github.com/hickory-dns/hickory-dns/commit/af34b4a728ed206f60e44f6c466c4db605a9ebd7) net: spawn_bg() doesn't handle errors - [`943201a`](https://github.com/hickory-dns/hickory-dns/commit/943201a295a0ccf8e1f4597f25ed17d7d055b298) net: move DnsTcpStream into runtime - [`3619ee8`](https://github.com/hickory-dns/hickory-dns/commit/3619ee8977560b8d9d6a9ec297da21c5161b5f7e) net: move DnsUdpSocket into runtime - [`8b81b3a`](https://github.com/hickory-dns/hickory-dns/commit/8b81b3aebb41395fcaf3a85782c0709ba17dadab) net: drop test-only Executor abstraction ### 📊 Changes **17 files changed** (+138 additions, -178 deletions) <details> <summary>View changed files</summary> 📝 `crates/net/src/h2/h2_client_stream.rs` (+3 -3) 📝 `crates/net/src/runtime.rs` (+66 -45) 📝 `crates/net/src/rustls/tls_client_stream.rs` (+6 -9) 📝 `crates/net/src/rustls/tls_stream.rs` (+7 -10) 📝 `crates/net/src/tcp/mod.rs` (+1 -1) 📝 `crates/net/src/tcp/tcp_client_stream.rs` (+2 -2) 📝 `crates/net/src/tcp/tcp_stream.rs` (+2 -8) 📝 `crates/net/src/udp/mod.rs` (+1 -1) 📝 `crates/net/src/udp/udp_client_stream.rs` (+2 -2) 📝 `crates/net/src/udp/udp_stream.rs` (+3 -42) 📝 `crates/net/src/xfer/dns_exchange.rs` (+3 -5) 📝 `crates/resolver/examples/custom_provider.rs` (+10 -9) 📝 `crates/resolver/src/name_server.rs` (+14 -17) 📝 `crates/resolver/src/name_server_pool.rs` (+1 -1) 📝 `crates/resolver/src/resolver.rs` (+11 -11) 📝 `tests/integration-tests/src/mock_client.rs` (+3 -6) 📝 `tests/test-support/src/lib.rs` (+3 -6) </details> ### 📄 Description Here's some work towards the hickory-tokio crate split as discussed in - #3313 I don't think that split works out as I thought, will comment in that issue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>